Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): Extract release health metrics from sessions #986

Merged
merged 21 commits into from
Apr 30, 2021
Merged

feat(metrics): Extract release health metrics from sessions #986

merged 21 commits into from
Apr 30, 2021

Conversation

jjbayer
Copy link
Member

@jjbayer jjbayer commented Apr 23, 2021 •
edited by jan-auer
Loading

  • Adds feature flags to project states. The first flag is to control metrics extraction.
  • Extract metrics from release health sessions in processing mode.
  • Extract metrics for breakdowns and measurements in transactions.

Depends on getsentry/sentry#25575.

@jan-auer jan-auer marked this pull request as ready for review April 26, 2021 10:31
@jan-auer jan-auer requested a review from a team April 26, 2021 10:31
jjbayer
jjbayer commented Apr 27, 2021
View reviewed changes
relay-server/src/actors/envelopes.rs Outdated
let received = state.received_at;
let extract_metrics = state.project_state.has_feature(Feature::MetricsExtraction);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-auer do we need to add && self.config.processing_enabled() here?

@jan-auer jan-auer merged commit e3c064e into master Apr 30, 2021
@jan-auer jan-auer deleted the feat/metrics-extraction branch April 30, 2021 06:25
@github-actions
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.
Instructions and example for changelog

For changes exposed to the Python package, please add an entry to py/CHANGELOG.md. This includes, but is not limited to event normalization, PII scrubbing, and the protocol.

For changes to the Relay server, please add an entry to CHANGELOG.md under the following heading:

  1. Features: For new user-visible functionality.
  2. Bug Fixes: For user-visible bug fixes.
  3. Internal: For features and bug fixes in internal operation, especially processing mode.

To the changelog entry, please add a link to this PR (consider a more descriptive message):

- Extract release health metrics from sessions. ([#986](https://github.com/getsentry/relay/pull/986))

If none of the above apply, you can opt out by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 13996d1

@jan-auer jan-auer mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjbayer @jan-auer