feat(suspect-spans): Add span exclusive time #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the computation for the span's exclusive time if it is enabled. The span's exclusive time can be understood as the amount of time spent in this span excluding the time spent in any immediate children.
dashed
reviewed
Aug 23, 2021
|
@Zylphrex will you be adding an E2E integration test for this PR? |
dashed
approved these changes
Aug 26, 2021
dashed
reviewed
Aug 26, 2021
jan-auer
reviewed
Aug 30, 2021
jan-auer
approved these changes
Aug 31, 2021
dashed
approved these changes
Aug 31, 2021
jan-auer
approved these changes
Sep 1, 2021
|
Good to merge, please view both of my comments as optional. |
Zylphrex
added a commit
that referenced
this pull request
Sep 10, 2021
Following up with #1061, this change adds the exclusive time calculation for the root span of a transaction.
Zylphrex
added a commit
that referenced
this pull request
Sep 22, 2021
Following up with #1061, this change adds the exclusive time calculation for the root span of a transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the computation for the span's exclusive time if it is enabled.
The span's exclusive time can be understood as the amount of time spent in this
span excluding the time spent in any immediate children.