feat(suspect-spans): Add span attributes to relay config #28134
Merged
+47
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a relay config to enable the computation of certain span level attributes. The initial iteration only includes the span's exclusive time.
k-fish
approved these changes
Aug 26, 2021
dashed
reviewed
Aug 26, 2021
Zylphrex
commented
Aug 26, 2021
Comment on lines
205
to
211
| assert [span["exclusive-time"] for span in raw_event["spans"]] == [ | ||
| pytest.approx(50), | ||
| pytest.approx(0), | ||
| pytest.approx(200), | ||
| pytest.approx(0), | ||
| pytest.approx(200), | ||
| ] |
There was a problem hiding this comment.
Dependent on getsentry/relay#1061
jan-auer
approved these changes
Aug 30, 2021
jan-auer
reviewed
Aug 30, 2021
| @@ -196,3 +201,11 @@ def test_transaction(self): | |||
| "total.time": {"value": pytest.approx(1050)}, | |||
| } | |||
| } | |||
|
|
|||
| assert [span["exclusive-time"] for span in raw_event["spans"]] == [ | |||
There was a problem hiding this comment.
Could you double-check the spelling here? Looks like this should be exclusive_time.
There was a problem hiding this comment.
This is from the event payload, right? Payload should be all snake_case. See the parsing test in Relay: https://github.com/getsentry/relay/pull/1061/files#diff-27bbe8166c22c9062d109bab3ce15e368ab09735ec71fd1d7bb5321744c3e07cR66
dashed
approved these changes
Aug 30, 2021
dashed
approved these changes
Sep 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a relay config to enable the computation of certain span level
attributes. The initial iteration only includes the span's exclusive time.
Related relay PR: getsentry/relay#1061