build: Use Centos 7 as base image for the linux build [INGEST-1340] #1279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // build a static library | ||
| .define("BUILD_SHARED_LIBS", "OFF") | ||
| // cmake sets the install dir to `lib64` sometimes, but rust expects `lib` | ||
| .define("CMAKE_INSTALL_LIBDIR", "lib") |
* master: fix(build): Use cli git to save ram with cargo (#1280)
andriisoldatenko
approved these changes
May 23, 2022
jan-auer
commented
May 23, 2022
|
|
||
| RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile minimal | ||
|
|
||
| COPY --from=sentry-cli /bin/sentry-cli /bin/sentry-cli |
There was a problem hiding this comment.
Moved this from the relay-builder stage to relay-deps. It looks like this was placed there to ensure we have a more recent sentry-cli, but since sentry-cli is now more stable, we can also copy it into the deps right away.
I can look into updating to sentry-cli v2 in a separate step.
mitsuhiko
approved these changes
May 23, 2022
tonyo
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves docker builds to a container based on CentOS 7, which is currently the oldest long-term supported Linux still under maintenance along with RHEL 7. This makes Relay compatible with glibc 2.17 or newer. Apart from CentOS and RHEL, this change also makes Relay compatible with the current AWS lambda runtime.
The main docker container published to the DockerHub registry continues to include
processingandcrash-handling, which comes with an additional dependency tocurl. To make this work under CentOS, there was a fix necessary in therelay-crashnative build to ensure the static library gets installed into the correct directory.A build with all binaries can be seen here (download artifacts).
Fixes #1137
cc @antonpirker