Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Use cli git to save ram with cargo #1280

Merged
merged 1 commit into from
May 23, 2022

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented May 21, 2022

Courtesy of @asottile-sentry in getsentry/symbolic#585. Reduces memory
consumption of docker builds.

Build runs: https://github.com/getsentry/relay/runs/6535776617?check_suite_focus=true

#skip-changelog

@jan-auer jan-auer self-assigned this May 21, 2022
@jan-auer jan-auer requested a review from a team May 21, 2022 08:14
@jan-auer
Copy link
Member Author

I've not seen such a memory leak in the main docker build yet, but will investigate this as part of #1279.

@jan-auer jan-auer requested a review from asottile-sentry May 21, 2022 08:15
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-auer jan-auer merged commit 263f935 into master May 23, 2022
@jan-auer jan-auer deleted the build/manylinux-git-cli branch May 23, 2022 14:53
jan-auer added a commit that referenced this pull request May 23, 2022
* master:
  fix(build): Use cli git to save ram with cargo (#1280)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants