Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(auth): Unflake re_auth_failure #1531

Merged
merged 2 commits into from
Oct 25, 2022
Merged

test(auth): Unflake re_auth_failure #1531

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bb2786
fix: Give Relay time to process response
jjbayer Oct 25, 2022
a36f121
test: shorter sleep
jjbayer Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/integration/test_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,6 +890,9 @@ def counted_check_challenge(*args, **kwargs):
auth_count_2 = counter[0]
assert auth_count_1 < auth_count_2

# Give Relay some time to process the auth response and mark itself as not ready
sleep(0.1)

# send a message, it should not come through while the authentication has failed
relay.send_event(project_id, {"message": "123"})
# sentry should have received nothing
Expand All @@ -906,6 +909,9 @@ def counted_check_challenge(*args, **kwargs):
auth_count_3 = counter[0]
assert auth_count_2 < auth_count_3

# Give Relay some time to process the auth response and mark itself as ready
sleep(0.1)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran this 10 times on a different branch, 0.1 seems to work fine:

https://github.com/getsentry/relay/actions/runs/3318797256/jobs/5483154174#step:10:662


# now we should be re-authenticated and we should have the event

# sanity test that we got the event we sent
Expand Down