test(auth): Unflake re_auth_failure #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
changed the title
jjbayer
force-pushed
the
test/re-auth-failure
branch
from
fb5f05f to
3bb2786
Compare
jjbayer
commented
Oct 25, 2022
| @@ -906,6 +909,9 @@ def counted_check_challenge(*args, **kwargs): | |||
| auth_count_3 = counter[0] | |||
| assert auth_count_2 < auth_count_3 | |||
|
|
|||
| # Give Relay some time to process the auth response and mark itself as ready | |||
| sleep(0.1) | |||
There was a problem hiding this comment.
Ran this 10 times on a different branch, 0.1 seems to work fine:
https://github.com/getsentry/relay/actions/runs/3318797256/jobs/5483154174#step:10:662
iker-barriocanal
approved these changes
Oct 25, 2022
jan-auer
added a commit
that referenced
this pull request
Oct 25, 2022
* master: release: 0.8.15 fix(py): Respect the renormalize flag (#1548) (fix)e2e: Use report self hosted issues env variable (#1539) meta(vscode): Enable all features in Rust-Analyzer (#1542) release: 0.8.14 build(craft): Fix manylinux artifact name (#1547) feat(quotas): New data category for indexed transactions (#1535) test(auth): Unflake re_auth_failure (#1531) replays: add warning log for parse errors (#1534) fix(server): Retain valid cached project states on error (#1426) feat(protocol): Implement response context schema (#1529) feat(replays): emit org_id on recording kafka messages (#1528) feat: Add .NET/Portable-PDB specific protocol fields (#1518) feat(quotas): Enforce rate limits on metrics buckets (#1515) ref(pii): Consider all token as sensitive [INGEST-1550] (#1527) release: 22.10.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in
test_re_auth_failure, Relay was able to process a new event before it changed itsauth_statefromRegisteredtoRegistering. The integration test waits for the sentry side to handle the failing auth request, but not for the Relay side to handle the failing auth response.#skip-changelog