Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(pii): Consider all token as sensitive [INGEST-1550] #1527

Merged
merged 4 commits into from
Oct 17, 2022

Conversation

olksdr
Copy link
Contributor

@olksdr olksdr commented Oct 13, 2022

Scrub all the fields where names end with token and make sure that safe_fields can be used to override the default scrubbing rule if needed.

The question to the team:

  • do we want to scrub anything that contains token instead? ~> Yes

#skip-changelog

@olksdr olksdr requested a review from a team October 13, 2022 15:28
@olksdr olksdr self-assigned this Oct 13, 2022
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I do think this deserves a changelog entry, both in CHANGELOG.md and in py/CHANGELOG.md.

@olksdr
Copy link
Contributor Author

olksdr commented Oct 17, 2022

@jjbayer Added the CHANGELOGs entries. PTAL!

@olksdr olksdr requested a review from jjbayer October 17, 2022 09:29
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left suggestions to make the changelog more specific, let me know if you agree.

py/CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
@olksdr olksdr merged commit 7b3ac3e into master Oct 17, 2022
@olksdr olksdr deleted the fix/remove-all-tokens branch October 17, 2022 10:09
jan-auer added a commit that referenced this pull request Oct 25, 2022
* master:
  release: 0.8.15
  fix(py): Respect the renormalize flag (#1548)
  (fix)e2e: Use report self hosted issues env variable (#1539)
  meta(vscode): Enable all features in Rust-Analyzer (#1542)
  release: 0.8.14
  build(craft): Fix manylinux artifact name (#1547)
  feat(quotas): New data category for indexed transactions (#1535)
  test(auth): Unflake re_auth_failure (#1531)
  replays: add warning log for parse errors (#1534)
  fix(server): Retain valid cached project states on error (#1426)
  feat(protocol): Implement response context schema (#1529)
  feat(replays): emit org_id on recording kafka messages (#1528)
  feat: Add .NET/Portable-PDB specific protocol fields (#1518)
  feat(quotas): Enforce rate limits on metrics buckets (#1515)
  ref(pii): Consider all token as sensitive [INGEST-1550] (#1527)
  release: 22.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants