fix(py): Respect the renormalize flag #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
changed the title
jan-auer
approved these changes
Oct 25, 2022
olksdr
approved these changes
Oct 25, 2022
jan-auer
added a commit
that referenced
this pull request
Oct 25, 2022
* master: release: 0.8.15 fix(py): Respect the renormalize flag (#1548) (fix)e2e: Use report self hosted issues env variable (#1539) meta(vscode): Enable all features in Rust-Analyzer (#1542) release: 0.8.14 build(craft): Fix manylinux artifact name (#1547) feat(quotas): New data category for indexed transactions (#1535) test(auth): Unflake re_auth_failure (#1531) replays: add warning log for parse errors (#1534) fix(server): Retain valid cached project states on error (#1426) feat(protocol): Implement response context schema (#1529) feat(replays): emit org_id on recording kafka messages (#1528) feat: Add .NET/Portable-PDB specific protocol fields (#1518) feat(quotas): Enforce rate limits on metrics buckets (#1515) ref(pii): Consider all token as sensitive [INGEST-1550] (#1527) release: 22.10.0
jan-auer
added a commit
that referenced
this pull request
Oct 25, 2022
* master: fix(gha): Skip Sentry integration tests on library release builds (#1550) ref: Use wildcard re-exports where applicable (#1526) ci(gha): Skip Sentry integration tests on library release builds (#1549) release: 0.8.15 fix(py): Respect the renormalize flag (#1548) (fix)e2e: Use report self hosted issues env variable (#1539) meta(vscode): Enable all features in Rust-Analyzer (#1542) release: 0.8.14 build(craft): Fix manylinux artifact name (#1547)
jan-auer
added a commit
that referenced
this pull request
Oct 27, 2022
* master: feat(quotas): Separate processing and indexing quotas (#1537) feat(replays): Adjust replay parser to be less strict and allow for larger segment-ids (#1551) fix(gha): Skip Sentry integration tests on library release builds (#1550) ref: Use wildcard re-exports where applicable (#1526) ci(gha): Skip Sentry integration tests on library release builds (#1549) release: 0.8.15 fix(py): Respect the renormalize flag (#1548) (fix)e2e: Use report self hosted issues env variable (#1539) meta(vscode): Enable all features in Rust-Analyzer (#1542)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
normalizein the python package and C-ABI receives a structure with config arguments for the various normalizers. Therenormalizeflag is more central, as it is supposed to disable most of the normalizers. This is used in Sentry after the event has passed normalization to ensure that it is still structurally valid, but it may contain fields now that are prohibited during ingestion.In #1366 large parts of normalization were split into a dedicated
light_normalizefunction which did not honor the renormalize flag. This PR restores correct behavior and disables the entire renormalize call.