ref: Use wildcard re-exports where applicable #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
Oct 13, 2022
| #[doc(inline)] | ||
| pub use relay_common::{ | ||
| CustomUnit, DurationUnit, FractionUnit, InformationUnit, MetricUnit, ParseMetricUnitError, | ||
| UnixTimestamp, |
There was a problem hiding this comment.
Was there a reason this was not under #[doc(inline)] before?
There was a problem hiding this comment.
I don't think so, looks like an oversight.
* master: release: 0.8.15 fix(py): Respect the renormalize flag (#1548) (fix)e2e: Use report self hosted issues env variable (#1539) meta(vscode): Enable all features in Rust-Analyzer (#1542) release: 0.8.14 build(craft): Fix manylinux artifact name (#1547) feat(quotas): New data category for indexed transactions (#1535) test(auth): Unflake re_auth_failure (#1531) replays: add warning log for parse errors (#1534) fix(server): Retain valid cached project states on error (#1426) feat(protocol): Implement response context schema (#1529) feat(replays): emit org_id on recording kafka messages (#1528) feat: Add .NET/Portable-PDB specific protocol fields (#1518) feat(quotas): Enforce rate limits on metrics buckets (#1515) ref(pii): Consider all token as sensitive [INGEST-1550] (#1527) release: 22.10.0
jan-auer
added a commit
that referenced
this pull request
Oct 25, 2022
* master: fix(gha): Skip Sentry integration tests on library release builds (#1550) ref: Use wildcard re-exports where applicable (#1526) ci(gha): Skip Sentry integration tests on library release builds (#1549) release: 0.8.15 fix(py): Respect the renormalize flag (#1548) (fix)e2e: Use report self hosted issues env variable (#1539) meta(vscode): Enable all features in Rust-Analyzer (#1542) release: 0.8.14 build(craft): Fix manylinux artifact name (#1547)
jan-auer
added a commit
that referenced
this pull request
Oct 27, 2022
* master: feat(quotas): Separate processing and indexing quotas (#1537) feat(replays): Adjust replay parser to be less strict and allow for larger segment-ids (#1551) fix(gha): Skip Sentry integration tests on library release builds (#1550) ref: Use wildcard re-exports where applicable (#1526) ci(gha): Skip Sentry integration tests on library release builds (#1549) release: 0.8.15 fix(py): Respect the renormalize flag (#1548) (fix)e2e: Use report self hosted issues env variable (#1539) meta(vscode): Enable all features in Rust-Analyzer (#1542)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, we export the entire public API of a module via the containing
parent module. The internal module structure is supposed to be an implementation
detail for code organization but does not matter to the public API. An example
for this is the Event protocol.
In most cases, we use wildcard exports
pub use module::*for this. Therelay-generalcrate did not do this. With modern tooling and code search, itis now equally easy to locate types. The benefit of using a wildcard export is
that we cannot forget to re-export types that would be then missing from the
public signature.
#skip-changelog