ci(gha): Skip Sentry integration tests on library release builds #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olksdr
approved these changes
Oct 25, 2022
jan-auer
added a commit
that referenced
this pull request
Oct 25, 2022
) Proper implementation of #1549 The "Sentry Relay Integration Tests" job should not run on library release builds, since it only tests the Relay server binary against Sentry, but doesn't test the library. The library release build is separate from binary release builds, and as such this test can be skipped safely.
jan-auer
added a commit
that referenced
this pull request
Oct 25, 2022
* master: fix(gha): Skip Sentry integration tests on library release builds (#1550) ref: Use wildcard re-exports where applicable (#1526) ci(gha): Skip Sentry integration tests on library release builds (#1549) release: 0.8.15 fix(py): Respect the renormalize flag (#1548) (fix)e2e: Use report self hosted issues env variable (#1539) meta(vscode): Enable all features in Rust-Analyzer (#1542) release: 0.8.14 build(craft): Fix manylinux artifact name (#1547)
jan-auer
added a commit
that referenced
this pull request
Oct 27, 2022
* master: feat(quotas): Separate processing and indexing quotas (#1537) feat(replays): Adjust replay parser to be less strict and allow for larger segment-ids (#1551) fix(gha): Skip Sentry integration tests on library release builds (#1550) ref: Use wildcard re-exports where applicable (#1526) ci(gha): Skip Sentry integration tests on library release builds (#1549) release: 0.8.15 fix(py): Respect the renormalize flag (#1548) (fix)e2e: Use report self hosted issues env variable (#1539) meta(vscode): Enable all features in Rust-Analyzer (#1542)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Sentry Relay Integration Tests" job should not run on library release
builds, since it only tests the Relay server binary against Sentry, but doesn't
test the library. The library release build is separate from binary release
builds, and as such this test can be skipped safely.
It is worth noting that there are currently no integration tests of the Relay
library with Sentry. Those should be added soon in a new PR, as the recently
failed release of 0.8.14 showed.
#skip-changelog