Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): Add OpenTelemetry Context #1617

Merged
merged 6 commits into from
Nov 22, 2022
Merged

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Nov 21, 2022

ref: #1615

Add a new Context field that is sent with OpenTelemetry Events. Documented here: https://develop.sentry.dev/sdk/performance/opentelemetry/#opentelemetry-context.

@AbhiPrasad AbhiPrasad requested review from sl0thentr0py and a team November 21, 2022 17:15
@AbhiPrasad AbhiPrasad self-assigned this Nov 21, 2022
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, shall we add a roundtrip test to the new module? See for example

pub(crate) fn test_trace_context_roundtrip() {
.

@AbhiPrasad
Copy link
Member Author

Looks good to me, shall we add a roundtrip test to the new module? See for example

Done in 87fac38!

@AbhiPrasad AbhiPrasad merged commit faee789 into master Nov 22, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-otel-context branch November 22, 2022 13:25
jan-auer added a commit that referenced this pull request Nov 24, 2022
* master:
  ref(system): Introduce a generic recipient type (#1622)
  feat(transaction): Normalize transaction name (#1621)
  feat(server): Track metrics for OpenTelemetry events (#1618)
  bug(replays): Increase reserved space in payload chunks (#1601)
  feat(protocol): Add OpenTelemetry Context (#1617)
jan-auer added a commit that referenced this pull request Nov 24, 2022
* master:
  chore(toolchain): Fix lint and test for beta toolchain (#1623)
  ref(system): Introduce a generic recipient type (#1622)
  feat(transaction): Normalize transaction name (#1621)
  feat(server): Track metrics for OpenTelemetry events (#1618)
  bug(replays): Increase reserved space in payload chunks (#1601)
  feat(protocol): Add OpenTelemetry Context (#1617)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants