Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(toolchain): Fix lint and test for beta toolchain #1623

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

olksdr
Copy link
Contributor

@olksdr olksdr commented Nov 24, 2022

Make sure we also prepare for the next Rust release.

This PR fixes lint for beta toolchain, and make sure all the tests are still passing.

#skip-changelog

@olksdr olksdr requested a review from a team November 24, 2022 07:26
@olksdr olksdr self-assigned this Nov 24, 2022
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do we also want to run this in CI, as a non-required check?

@olksdr
Copy link
Contributor Author

olksdr commented Nov 24, 2022

Nice! Do we also want to run this in CI, as a non-required check?

We do have this in CI https://github.com/getsentry/relay/actions/workflows/beta.yml and it runs periodically.

Maybe adding this to our common CI runs will bring more benefits. But also sometimes beta has something which stable does not support yet, and it is just not possible to fix it on both at the same time, so we will be having 1 red job.

relay-general/src/types/meta.rs Outdated Show resolved Hide resolved
Co-authored-by: Jan Michael Auer <mail@jauer.org>
@olksdr olksdr enabled auto-merge (squash) November 24, 2022 13:57
@olksdr olksdr merged commit a1a12a0 into master Nov 24, 2022
@olksdr olksdr deleted the chore/work-beta-work branch November 24, 2022 14:15
jan-auer added a commit that referenced this pull request Nov 24, 2022
* master:
  chore(toolchain): Fix lint and test for beta toolchain (#1623)
  ref(system): Introduce a generic recipient type (#1622)
  feat(transaction): Normalize transaction name (#1621)
  feat(server): Track metrics for OpenTelemetry events (#1618)
  bug(replays): Increase reserved space in payload chunks (#1601)
  feat(protocol): Add OpenTelemetry Context (#1617)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants