feat(threads): Add state as an optional key in the threads interface #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thread state is currently sent by the Android SDK but isn't extracted. We want to extract and store it on the event json.
iker-barriocanal
approved these changes
Mar 2, 2023
| @@ -9,6 +9,7 @@ | |||
| - Strip quotes from client hint values. ([#1874](https://github.com/getsentry/relay/pull/1874)) | |||
| - Add Dotnet, Javascript and PHP support for profiling. ([#1871](https://github.com/getsentry/relay/pull/1871), [#1876](https://github.com/getsentry/relay/pull/1876), [#1885](https://github.com/getsentry/relay/pull/1885)) | |||
| - Scrub `span.data.http.query` with default scrubbers. ([#1889](https://github.com/getsentry/relay/pull/1889)) | |||
| - Add `thread.state` field to protocol. ([#1896](https://github.com/getsentry/relay/pull/1896)) | |||
There was a problem hiding this comment.
Please also add an entry to py/CHANGELOG.md.
iker-barriocanal
suggested changes
Mar 2, 2023
| @@ -125,6 +125,10 @@ pub struct Thread { | |||
| /// A flag indicating whether the thread was responsible for rendering the user interface. | |||
| pub main: Annotated<bool>, | |||
|
|
|||
| /// Thread state at the time of the crash. | |||
| #[metastructure(skip_serialization = "empty")] | |||
| pub state: Annotated<String>, | |||
There was a problem hiding this comment.
Now that I'm thinking about it, it's probably best to make this an enum instead. From your PR description, I assume you're focusing mostly on Android for now, and you link to two places where there's a list of possible values. We can start from these.
iker-barriocanal
approved these changes
Mar 2, 2023
shruthilayaj
added a commit
to getsentry/sentry
that referenced
this pull request
Mar 6, 2023
Thread state is an optional string currently sent by the Android SDK on the threads interface but isn't extracted. We want to extract and store it on the event json. We don't anticipate running any queries against this field. Corresponding relay changes (getsentry/relay#1896).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread state is an optional string currently sent by the Android SDK on the threads interface but isn't extracted. We want to extract and store it on the event json. Currently, we capture the JVM states, but in the ANRv2 implementation, we expect to capture to states the Android VM provides. Note, these values are for Android only, other SDKs could send other values.
We only need to save thread state in nodestore, we don't anticipate running any queries against this field.
Here is an example event payload with thread states.
closes getsentry/sentry#45196