Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract thread state in the threads interface in relay #45196

Closed
Tracked by #44502
shruthilayaj opened this issue Feb 28, 2023 · 1 comment · Fixed by getsentry/relay#1896
Closed
Tracked by #44502

Extract thread state in the threads interface in relay #45196

shruthilayaj opened this issue Feb 28, 2023 · 1 comment · Fixed by getsentry/relay#1896
Assignees
@shruthilayaj

Comments

@shruthilayaj
Copy link
Member

shruthilayaj commented Feb 28, 2023 •
edited
Loading

Thread state is currently sent by the Android SDK but isn't extracted. We want to extract and store it on the event json. Currently, we capture the JVM states, but in the ANRv2 implementation, we expect to capture to states the Android VM provides. Note, these values are for Android only, other SDKs could send other values.

We only need to save thread state in nodestore, we don't anticipate running any queries against this field.
@shruthilayaj shruthilayaj mentioned this issue Feb 28, 2023
Closed
9 tasks
@shruthilayaj shruthilayaj self-assigned this Feb 28, 2023
@shruthilayaj shruthilayaj mentioned this issue Feb 28, 2023
Merged
@getsantry
Copy link
Contributor

getsantry bot commented Mar 1, 2023

Routing to @getsentry/team-mdx for triage, due by Friday, March 3rd at 15:22 (yyz). ⏲️

shruthilayaj added a commit to getsentry/relay that referenced this issue Mar 2, 2023
@shruthilayaj
feat(threads): Add state as an optional key in the threads interface (#…
e7c862e 
…1896)

Thread state is an optional string currently sent by the Android SDK on
the threads interface but isn't extracted. We want to extract and store
it on the event json. Currently, we capture the JVM
[states](https://docs.oracle.com/javase/7/docs/api/java/lang/Thread.State.html),
but in the ANRv2 implementation, we expect to capture to states the
Android VM
[provides](https://cs.android.com/android/platform/superproject/+/master:art/runtime/thread_state.h).
Note, these values are for Android only, other SDKs could send other
values.

We only need to save thread state in nodestore, we don't anticipate
running any queries against this field.


[Here](https://gist.github.com/shruthilayaj/2151eac05009466f4549c5f2ad48a11f)
is an example event payload with thread states.

closes getsentry/sentry#45196
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shruthilayaj shruthilayaj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(threads): Add state as an optional key in the threads interface getsentry/relay
1 participant
@shruthilayaj