Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Apply import grouping from coding style #1921

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Mar 13, 2023

Applies the Sentry import order guidelines on the entire codebase. One notable difference is that public re-exports (pub use) are grouped with other imports.

On top of default settings, this is equivalent to the following rustfmt configuration:

imports_granularity = "Module"
group_imports = "StdExternalCrate"  # nightly only

Since the latter option is nightly-only at the time of this PR, we do not add a rustfmt configuration to the codebase yet. For more information on the used options, refer to the official documentation.

See also getsentry/develop#869.

#skip-changelog

@jan-auer jan-auer requested review from a team as code owners March 13, 2023 08:56
@jan-auer jan-auer requested a review from a team March 13, 2023 08:56
Copy link
Contributor

@olksdr olksdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jan-auer jan-auer self-assigned this Mar 13, 2023
@jan-auer jan-auer added this to the Maintenance milestone Mar 13, 2023
* master:
  feat(general): Fix leaked ip address (#1892)
@jan-auer jan-auer enabled auto-merge (squash) March 13, 2023 09:50
@jan-auer jan-auer merged commit 66d6d8d into master Mar 13, 2023
@jan-auer jan-auer deleted the chore/group-imports branch March 13, 2023 10:15
jan-auer added a commit that referenced this pull request Mar 13, 2023
* master:
  chore: Apply import grouping from coding style (#1921)
  feat(general): Fix leaked ip address (#1892)
  fix(normalize): No original_value for untouched transactions (#1916)
  chore(build): Update rust toolchain to 1.68.0 (#1914)
  ref(buffering): Move the buffering to the dedicated service (#1909)
  ref(monitors): Use monitor_slug over monitor_id (#1905)
jan-auer added a commit that referenced this pull request Mar 17, 2023
…or-slug-parameter

* master: (21 commits)
  ci: switch to using GitHub artefacts instead of ghcr for PR testing (#1918)
  ref: Add new mobile vitals (#1943)
  release: 23.3.0
  ref(profiling): Remove platform validation (#1933)
  ref(relay_cache): Inject upstream realy into the service (#1932)
  feat(csp): Add the request's origin to CSP events (#1934)
  chore(common): Remove unused tryf macro (#1931)
  ref(test): Remove actix test utilities (#1930)
  ref(actix): Refactor shutdown without actix (#1912)
  ref(outcomes): Do not use registry in outcome producer (#1927)
  ref: Inject services in project cache and project upstream (#1926)
  feat(config): Add links to docs in YAML config file (#1923)
  feat(mobile): Move device.class from contexts to tags (#1911)
  fix(ci): Use correct Rust toolchain in Beta CI (#1925)
  ci(gha): Remove unmaintained actions-rs actions (#1922)
  feat(normalization): Optionally mark scrubbed transactions as sanitized (#1917)
  chore: Apply import grouping from coding style (#1921)
  feat(general): Fix leaked ip address (#1892)
  fix(normalize): No original_value for untouched transactions (#1916)
  chore(build): Update rust toolchain to 1.68.0 (#1914)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants