ref(profiling): Remove platform validation #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
approved these changes
Mar 15, 2023
jernejstrasner
approved these changes
Mar 15, 2023
jan-auer
added a commit
that referenced
this pull request
Mar 17, 2023
…or-slug-parameter * master: (21 commits) ci: switch to using GitHub artefacts instead of ghcr for PR testing (#1918) ref: Add new mobile vitals (#1943) release: 23.3.0 ref(profiling): Remove platform validation (#1933) ref(relay_cache): Inject upstream realy into the service (#1932) feat(csp): Add the request's origin to CSP events (#1934) chore(common): Remove unused tryf macro (#1931) ref(test): Remove actix test utilities (#1930) ref(actix): Refactor shutdown without actix (#1912) ref(outcomes): Do not use registry in outcome producer (#1927) ref: Inject services in project cache and project upstream (#1926) feat(config): Add links to docs in YAML config file (#1923) feat(mobile): Move device.class from contexts to tags (#1911) fix(ci): Use correct Rust toolchain in Beta CI (#1925) ci(gha): Remove unmaintained actions-rs actions (#1922) feat(normalization): Optionally mark scrubbed transactions as sanitized (#1917) chore: Apply import grouping from coding style (#1921) feat(general): Fix leaked ip address (#1892) fix(normalize): No original_value for untouched transactions (#1916) chore(build): Update rust toolchain to 1.68.0 (#1914) ...
jan-auer
added a commit
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's align with the event protocol and not validate platform for profiles.
runtimeis not a required field, the profile is valid even if those fields are omitted. I'd remove the validation forcocoaas well but we do have some code relying on these fields for Snuba ingestion so we'll need to deal with that first in order to treat everything as optional like for the event.We can close #1902 in favor of this.