-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(general): Indicate if OS-version may be frozen #1945
Conversation
@@ -191,7 +210,7 @@ OsContext { | |||
let headers = vec![ | |||
Annotated::new(( | |||
Annotated::new("user-agent".to_string().into()), | |||
Annotated::new(r#"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36"#.to_string().into()), | |||
Annotated::new(r#"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36"#.to_string().into()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I wanted to test this functionality in a separate test, I changed the version here so that it wouldn't trigger the '>=' prefix
Before we decide to take this option, what about the option of adding extra metadata that we can render in the UI? So if we detect that an os-version may be frozen, we send additional info down with the event that the UI/product can use to indicate this (maybe even tell people about client hints). |
like a tooltip info giving some more info sounds good to me, although I don't think our users can do much about it. If the end-user doesn't have client hints they would have to switch to a browser that supports it. would it be too primitive to simply do an equality check in the UI? if version == ">=10" then show tooltip? |
I think this makes a lot of sense to me. We should probably then create a GH issue to track this after this gets merged in! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Please also add a unit test for the Windows case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Implements the following Sentry-PR: getsentry/sentry#45369
Figured relay would be a better fit, a benefit to implementing it in relay is that the OS-version is only potentially frozen if it's from the user-agent, not from the client hints, which is easier to figure out here.