Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inbound filters): Add Firefox "dead object" error to browser extension filter #2215

Merged
merged 3 commits into from
Jun 14, 2023
Merged

feat(inbound filters): Add Firefox "dead object" error to browser extension filter #2215

merged 3 commits into from
Jun 14, 2023

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Jun 13, 2023 •
edited
Loading

This adds “can’t access dead object” to the browser extension inbound filter. From the Mozilla blog post on the topic:

Firefox 15 introduced a major improvement in memory usage, by disallowing add-ons to keep references to DOM objects after their parent document was destroyed. This eliminates the most common cause of memory leaks in add-ons, and should reduce memory consumption for many users.

If you install an add-on that causes this kind of memory leak, starting with Firefox 15 you’ll see errors like this in the Error Console:

Error: TypeError: can't access dead object
Source File: chrome://addon/content/file.js
Line: 42

This means that Firefox did the right thing and prevented the add-on from holding on to this object. However, it also means that the add-on probably won’t work correctly.

Ref: getsentry/sentry#49520

@lobsterkatie lobsterkatie force-pushed the kmclb-add-dead-object-to-browser-extension-filter branch from 4a52511 to 87143e6 Compare June 13, 2023 16:05
@lobsterkatie lobsterkatie force-pushed the kmclb-add-dead-object-to-browser-extension-filter branch from 87143e6 to 0b23714 Compare June 13, 2023 16:19
@lobsterkatie lobsterkatie mentioned this pull request Jun 13, 2023
Closed
@lobsterkatie lobsterkatie requested a review from scttcper June 13, 2023 16:56
@lobsterkatie lobsterkatie marked this pull request as ready for review June 13, 2023 16:56
@lobsterkatie lobsterkatie requested a review from a team June 13, 2023 16:56
iker-barriocanal
iker-barriocanal approved these changes Jun 14, 2023
View reviewed changes
relay-filter/src/browser_extensions.rs
@@ -252,6 +255,7 @@ mod tests {
"plugin.setSuspendState is not a function",
"Extension context invalidated",
"useless error webkit-masked-url: please filter",
"TypeError: can't access dead object because dead stuff smells bad",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@lobsterkatie lobsterkatie merged commit 6c6296c into master Jun 14, 2023
@lobsterkatie lobsterkatie deleted the kmclb-add-dead-object-to-browser-extension-filter branch June 14, 2023 16:34
@lobsterkatie lobsterkatie linked an issue Jun 14, 2023 that may be closed by this pull request
Investigate server filter for Dead object firefox garbage getsentry/sentry#49520
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

@scttcper scttcper scttcper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate server filter for Dead object firefox garbage
3 participants
@lobsterkatie @scttcper @iker-barriocanal