Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inbound filters): Add Firefox "dead object" error to browser extension filter #2215

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- Add `lock` attribute to the frame protocol. ([#2171](https://github.com/getsentry/relay/pull/2171))
- Reject profiles longer than 30s. ([#2168](https://github.com/getsentry/relay/pull/2168))
- Change default topic for transaction metrics to `ingest-performance-metrics`. ([#2180](https://github.com/getsentry/relay/pull/2180))
- Add Firefox "dead object" error to browser extension filter ([#2215](https://github.com/getsentry/relay/pull/2215))

**Internal**:

Expand Down
8 changes: 6 additions & 2 deletions relay-filter/src/browser_extensions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ static EXTENSION_EXC_VALUES: Lazy<Regex> = Lazy::new(|| {
plugin\.setSuspendState\sis\snot\sa\sfunction|
# Chrome extension message passing failure
Extension\scontext\sinvalidated|
webkit-masked-url:
webkit-masked-url:|
# Firefox message when an extension tries to modify a no-longer-existing DOM node
# See https://blog.mozilla.org/addons/2012/09/12/what-does-cant-access-dead-object-mean/
can't\saccess\sdead\sobject
"#,
)
.expect("Invalid browser extensions filter (Exec Vals) Regex")
Expand Down Expand Up @@ -252,6 +255,7 @@ mod tests {
"plugin.setSuspendState is not a function",
"Extension context invalidated",
"useless error webkit-masked-url: please filter",
"TypeError: can't access dead object because dead stuff smells bad",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

];

for exc_value in &exceptions {
Expand All @@ -260,7 +264,7 @@ mod tests {
assert_ne!(
filter_result,
Ok(()),
"Event filter not recognizing events with known values {exc_value}"
"Event filter not recognizing events with known value '{exc_value}'"
)
}
}
Expand Down