feat(spans): Extract main_thread tag for spans #2761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
reviewed
Nov 23, 2023
| .and_then(|value| value.as_str()) | ||
| { | ||
| if thread_name == MAIN_THREAD_NAME { | ||
| span_tags.insert(SpanTagKey::MainTread, "true".to_owned()); |
There was a problem hiding this comment.
Can we limit this to MOBILE_SDKS.contains(...), like the Mobile tag?
jjbayer
approved these changes
Nov 24, 2023
| @@ -128,6 +132,7 @@ pub(crate) fn extract_span_tags(event: &mut Event, config: &Config) { | |||
| // TODO: To prevent differences between metrics and payloads, we should not extract tags here | |||
| // when they have already been extracted by a downstream relay. | |||
| let shared_tags = extract_shared_tags(event); | |||
| let sdk_name = event.sdk_name().to_owned(); | |||
There was a problem hiding this comment.
nit: It would be slightly cheaper to set let is_mobile = MOBILE_SDKS.contains(event.sdk_name()) here, and plug that into extract_tags.
Or even reuse the value that extract_shared_tags wrote to shared_tags.get(SpanTagKey::Mobile).
There was a problem hiding this comment.
good idea! just passing an is_mobile boolean now https://github.com/getsentry/relay/pull/2761/files#diff-313f39c52849630c10c4f6da270c2ed0f99d7deac8894a838bd166dddc94b19dR135
jjbayer
approved these changes
Nov 27, 2023
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
jan-auer
added a commit
that referenced
this pull request
Nov 29, 2023
* master: (27 commits) ref(metric-meta): Add metric for total incoming metric meta (#2784) feat(server): Return global config status for downstream requests (#2765) ref(processor): Create event processor sub-module with related code (#2779) fix(metrics): Temporarily restore previous configuration keys for bucket splitting (#2780) feat(metrics): Add source context to code locations (#2781) ref(processor): Split off profile processor code into separate sub-module (#2778) ref(processor): Split off replay processing code into separate sub-module (#2776) ref(metrics): Partition and split metrics buckets just before sending (#2682) feat(spans): Allow well-known path segments in resource URLs (#2770) ref(processor): Move user and client reports processing into separate submodule (#2772) ref(crons): Include message_type in kafka message (#2723) ref(spans): Split tag mapping in specific configs (#2773) release: 23.11.2 feat(metric-meta): Normalize invalid metric names (#2769) feat(spans): Extract main_thread tag for spans (#2761) Add DE Deployments (#2746) ref(processor): Move sessions related code into separate sub-module (#2768) ref(metric-meta): Capture envelope payload in a sentry issue (#2767) release: 0.8.38 ref(normalization): Restore span processing to transactionprocessor (#2764) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts main_thread tag for spans based on span[data][thread.name].
Right now, we only expect to extract this if thread name is
main.#skip-changelog