feat(metric-meta): Normalize invalid metric names #2769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
fix/mri-dash-in-name
branch
from
de7478f to
6c50403
Compare
|
We should normalize |
Dav1dde
changed the title
Dav1dde
force-pushed
the
fix/mri-dash-in-name
branch
from
6c50403 to
2163520
Compare
Dav1dde
changed the title
Dav1dde
force-pushed
the
fix/mri-dash-in-name
branch
from
2163520 to
539ca5d
Compare
jan-auer
reviewed
Nov 27, 2023
Dav1dde
changed the title
Dav1dde
force-pushed
the
fix/mri-dash-in-name
branch
from
539ca5d to
7e721be
Compare
jan-auer
approved these changes
Nov 27, 2023
Consecutive invalid characters will be replaced with a single underscore. Metric names still need to start with a valid character.
Dav1dde
force-pushed
the
fix/mri-dash-in-name
branch
from
7e721be to
ea5fbc0
Compare
jan-auer
added a commit
that referenced
this pull request
Nov 29, 2023
* master: (27 commits) ref(metric-meta): Add metric for total incoming metric meta (#2784) feat(server): Return global config status for downstream requests (#2765) ref(processor): Create event processor sub-module with related code (#2779) fix(metrics): Temporarily restore previous configuration keys for bucket splitting (#2780) feat(metrics): Add source context to code locations (#2781) ref(processor): Split off profile processor code into separate sub-module (#2778) ref(processor): Split off replay processing code into separate sub-module (#2776) ref(metrics): Partition and split metrics buckets just before sending (#2682) feat(spans): Allow well-known path segments in resource URLs (#2770) ref(processor): Move user and client reports processing into separate submodule (#2772) ref(crons): Include message_type in kafka message (#2723) ref(spans): Split tag mapping in specific configs (#2773) release: 23.11.2 feat(metric-meta): Normalize invalid metric names (#2769) feat(spans): Extract main_thread tag for spans (#2761) Add DE Deployments (#2746) ref(processor): Move sessions related code into separate sub-module (#2768) ref(metric-meta): Capture envelope payload in a sentry issue (#2767) release: 0.8.38 ref(normalization): Restore span processing to transactionprocessor (#2764) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry currently generates metrics with dashes in their names. Generally we want to normalize invalid metric names instead of dropping them. The Python SDK already has this logic, we're now also implementing it in relay.
Consecutive invalid characters will be replaced with a single underscore. Metric names still need to start with a valid character.