feat(general): Add thread.errored attribute #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
Nov 9, 2019
marandaneto
approved these changes
Nov 11, 2019
jan-auer
added a commit
that referenced
this pull request
Nov 13, 2019
* master: ref: Revert changes to HttpServer startup (#313) meta: Changelog for 0.4.61 feat(general): Add thread.errored attribute (#306) release: 0.4.60 doc: Changelog for 0.4.60 fix: Start clientconnector earlier fix: Spawn http server on separate thread (#312) feat: More concurrency options (#311) fix: Formatting fix: Ignore venv of load tests feat(load-tests): Added semaphore-load-test project back into semaphore (#309)
jan-auer
added a commit
that referenced
this pull request
Nov 13, 2019
* feat/envelopes: (110 commits) ref: Revert changes to HttpServer startup (#313) meta: Changelog for 0.4.61 feat(general): Add thread.errored attribute (#306) fix(config): Add a default for the attachment chunk size feat(server): Add back missing release and env for security reports feat: Re-introduce security report normalization feat(server): Implement sending of attachments to Kafka release: 0.4.60 doc: Changelog for 0.4.60 ref(server): Use envelopes to encapsulate EventMeta fix: Start clientconnector earlier fix: Spawn http server on separate thread (#312) ref(server): Unify incoming and outgoing envelopes fix(clippy): Implement Default for EventId fix(server): Add serialization for incoming envelopes ref(server): Move python shim logic to store endpoint feat(general): Create a constructor for EventId wip: Restructure EventProcessor to work on envelopes feat: More concurrency options (#311) fix: Formatting ...
jan-auer
added a commit
that referenced
this pull request
Dec 16, 2019
jan-auer
added a commit
that referenced
this pull request
Dec 17, 2019
* master: fix: Update fixture to produce stable snapshot fix: Check in missing snapshot ref: Bump sentry-types test(general): Add a snapshot for Android Revert "feat(general): Add thread.errored attribute (#306)" (#366) Revert "doc: Changelog for 0.4.66" doc: Changelog for 0.4.66 fix(server): Make status codes consistent with Sentry (#365) release: 0.4.65 test: Update security report test snapshots build: Update redis dependency meta: Changelog for 0.4.65 Revert "ref: Use jemalloc instead of system allocator (#344)" (#360) ref: Update user-agent database (#363) build: Update rdkafka to replace git dependency (#364)
jan-auer
added a commit
that referenced
this pull request
Dec 18, 2019
* master: fix(server): Preserve event id of minidump upload (#361) fix: Update fixture to produce stable snapshot fix: Check in missing snapshot ref: Bump sentry-types test(general): Add a snapshot for Android Revert "feat(general): Add thread.errored attribute (#306)" (#366) Revert "doc: Changelog for 0.4.66" doc: Changelog for 0.4.66 fix(server): Make status codes consistent with Sentry (#365) release: 0.4.65 test: Update security report test snapshots build: Update redis dependency meta: Changelog for 0.4.65 Revert "ref: Use jemalloc instead of system allocator (#344)" (#360) ref: Update user-agent database (#363) build: Update rdkafka to replace git dependency (#364)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
erroredattribute on the Threads interface.Formally, we used
crashedto indicate both errors and crashes in a thread. With NDK and Java, we now need to disambiguate between threads that have just errored, and threads that have caused an application crash.This will require follow-up work in the Sentry UI (Threads component) to display properly.