fix: Preserve event id of minidump upload #361
Conversation
There was a problem hiding this comment.
Unfortunately, this is not sufficient. We also need to parse this from other payloads. Ideally, we would abstract over that, given that we already have this helper in another place. If I remember correctly, then there are the following ways to ingest an event ID with minidumps:
- The
sentrykey containing a JSON-encoded payload - The
sentry[event_id]key containing the event ID - The
__sentry-eventmessagepack payload - If we want to support it going forward (did not support in the past), the
guidform field - Random generated.
You can see these different extractions in EventProcessor::extract_event.
yeah so this is where my confusion starts. We can abstract over it, but then we will probably just pay the cost of parsing everything twice... once in the endpoint and once in the event processing. |
Most likely we have to do that :( |
|
@jan-auer do you think we could get away with parsing the event ID only from a few select places and preventing it from being set in others? I.e. we allow |
|
Unfortunately, we have to support both the |
* master: fix: Update fixture to produce stable snapshot fix: Check in missing snapshot ref: Bump sentry-types test(general): Add a snapshot for Android Revert "feat(general): Add thread.errored attribute (#306)" (#366) Revert "doc: Changelog for 0.4.66" doc: Changelog for 0.4.66 fix(server): Make status codes consistent with Sentry (#365) release: 0.4.65 test: Update security report test snapshots build: Update redis dependency meta: Changelog for 0.4.65 Revert "ref: Use jemalloc instead of system allocator (#344)" (#360) ref: Update user-agent database (#363) build: Update rdkafka to replace git dependency (#364)
This reverts commit 1ea2e43.
* master: fix(server): Preserve event id of minidump upload (#361) fix: Update fixture to produce stable snapshot fix: Check in missing snapshot ref: Bump sentry-types test(general): Add a snapshot for Android Revert "feat(general): Add thread.errored attribute (#306)" (#366) Revert "doc: Changelog for 0.4.66" doc: Changelog for 0.4.66 fix(server): Make status codes consistent with Sentry (#365) release: 0.4.65 test: Update security report test snapshots build: Update redis dependency meta: Changelog for 0.4.65 Revert "ref: Use jemalloc instead of system allocator (#344)" (#360) ref: Update user-agent database (#363) build: Update rdkafka to replace git dependency (#364)
No description provided.