-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replays): Add ReplayVideo envelope item type #3105
Merged
Merged
Changes from 69 commits
Commits
Show all changes
87 commits
Select commit
Hold shift + click to select a range
e775838
feat(replay): combined envelope items
JoshFerge dc26a9d
only run in processing mode
JoshFerge 7033ae0
add integration test. fix processing mode stuff, add store logic
JoshFerge 2c9d294
remove processing mode business, use vec instead of Bytes
JoshFerge aa0c0ce
fix args in combined store func
JoshFerge 9d21e80
fix tests
JoshFerge d7d18bb
remove unused test
JoshFerge 5ce488b
merge
JoshFerge 5ad1304
get it compiling
JoshFerge da62bb8
get tests running
JoshFerge 8dbe24c
remove unused imports
JoshFerge e29cabf
make clippy even more happy
JoshFerge 3b96c66
add changelog entry
JoshFerge 6f7433e
move logic to store
JoshFerge 6f825d4
fix
JoshFerge aa4d3be
fix merge
JoshFerge 8d06df8
more cleanup
JoshFerge d8662fa
Update CHANGELOG.md
JoshFerge 91eeda5
remove feature
JoshFerge 848a513
use flag in header
JoshFerge 6399ce8
merge
JoshFerge 0540710
try to debug
JoshFerge 562c5ef
tests working
JoshFerge 43dd578
dont produce two messages
JoshFerge b9f7156
cleanup
JoshFerge c8726f3
remove println
JoshFerge 27b508d
fix lint
JoshFerge f625668
combined_payload not used in non-processing, allow dead code
JoshFerge 8d0e335
Update relay-server/src/envelope.rs
JoshFerge fa4afd2
simplify processing feature declare on env item flag
JoshFerge 6383eb0
move logic into one func
JoshFerge 9224202
clean refactor
JoshFerge f56ab35
add one final test / fix impl
JoshFerge 3b52610
small refactor to produce function
JoshFerge 50de8a2
Merge branch 'master' into jferg/combine-replay-env-items
JoshFerge b362d06
Merge branch 'master' into cmanallen/replays-add-video-envelope-item
cmanallen 3a71696
Add ReplayVideo envelope item type
cmanallen 1ae7767
Merge branch 'master' into jferg/combine-replay-env-items
JoshFerge bdb0345
Add video envelope item validator
cmanallen e7bc952
Add ReplayVideo item type processor
cmanallen 0331a1f
Send optional replay_video field in Kafka payload
cmanallen 8208ea4
Register outcome, rate-limit, and processing error
cmanallen 3805bf5
Merge branch 'jferg/combine-replay-env-items' into cmanallen/replays-…
cmanallen 67c0605
Compute payload through addition
cmanallen 898da00
Add docs
cmanallen bab9202
Update changelog
cmanallen 7baee11
Re-phrase changelog entry
cmanallen 35dd886
only produce replay events if replay recording / event exists
JoshFerge acbaa9e
Merge branch 'jferg/combine-replay-env-items' into cmanallen/replays-…
cmanallen 12ce170
Remove redundant boolean condition
cmanallen 70e20f3
Flatten extraction and consider replay_event size when measuring payl…
cmanallen 68c5a02
Replay-event variable is only populated if the flag is enabled
cmanallen 306245a
Remove redundant method
cmanallen 6ad66f9
Remove isize note
cmanallen 2959b9d
Correct boolean condition
cmanallen b96ca07
Emit outcome if the payload is too large
cmanallen b363dbf
Merge branch 'jferg/combine-replay-env-items' into cmanallen/replays-…
cmanallen fb1480f
Rename error and update comments
cmanallen a44c578
Merge branch 'master' into cmanallen/replays-add-video-envelope-item
cmanallen 0fa4678
Add replay-video test coverage
cmanallen 7a3ee9d
Remove unused test case
cmanallen c492902
Add support for SDK merged replay-video envelope item
cmanallen 279660e
Set processing items on the envelope item's headers
cmanallen c2227d4
Update store to accept combined ReplayVideo item type
cmanallen 7db085e
Fix lint
cmanallen cb024ce
Add ReplayVideo to ReplayGroup
cmanallen 8ffa74a
Add serde_bytes
cmanallen 3d81a06
Add test_replay_videos test module
cmanallen b49f9d5
Remove unused import
cmanallen bed786b
Pass drop as an Outcome and allow the outerscope to manage how that o…
cmanallen ec4539e
Merge branch 'master' into cmanallen/replays-add-video-envelope-item
cmanallen c95f6a4
Revert "Pass drop as an Outcome and allow the outerscope to manage ho…
cmanallen e6e193c
ref(replays): video item (#3149)
jjbayer d2583bb
Merge branch 'cmanallen/replays-add-video-envelope-item' of https://g…
cmanallen 22d2091
Update changelog
cmanallen 10be625
Merge branch 'master' into cmanallen/replays-add-video-envelope-item
cmanallen 10bfd11
Merge branch 'master' into cmanallen/replays-add-video-envelope-item
cmanallen 8dc8503
Produce replay-event to the snuba consumer
cmanallen 3417572
Merge branch 'cmanallen/replays-add-video-envelope-item' of https://g…
cmanallen 152ceb3
Create a new Bytes struct with a copy of the replay-event bytes
cmanallen 5109bb9
Use copy_from_slice
cmanallen 79b0668
Add replay-video produced metric
cmanallen eb8343c
Merge branch 'master' into cmanallen/replays-add-video-envelope-item
cmanallen b5b90e5
Abstract replay-event assertion and use in replay-video coverage
cmanallen af2cde7
Assert retention days
cmanallen 1d7ffdb
Emit a single metric
cmanallen 45c2bb8
Remove copy
cmanallen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this to the
## Unreleased
section.