feat(replays): Add ReplayVideo envelope item type #3105
Conversation
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
…utcome is handled
…w that outcome is handled" This reverts commit bed786b.
Serialize processed replay video item back into the envelope instead of putting it on the header. #skip-changelog
…ithub.com/getsentry/relay into cmanallen/replays-add-video-envelope-item
CHANGELOG.md
Outdated
| @@ -28,6 +28,7 @@ | |||
| **Features**: | |||
|
|
|||
| - Add protobuf support for ingesting OpenTelemetry spans and use official `opentelemetry-proto` generated structs. ([#3044](https://github.com/getsentry/relay/pull/3044)) | |||
| - Adds ReplayVideo envelope-item type. ([#3105](https://github.com/getsentry/relay/pull/3105)) | |||
There was a problem hiding this comment.
Please move this to the ## Unreleased section.
| @@ -97,6 +96,7 @@ reqwest = { version = "0.11.1", features = [ | |||
| rmp-serde = "1.1.1" | |||
| rust-embed = { version = "8.0.0", optional = true } | |||
| serde = { workspace = true } | |||
| serde_bytes = "0.11" | |||
There was a problem hiding this comment.
This is a crate by the creators of serde, so adding it as dependency should be fine.
…ithub.com/getsentry/relay into cmanallen/replays-add-video-envelope-item
relay-server/src/services/store.rs
Outdated
| self.produce_replay_event( | ||
| event_id.ok_or(StoreError::NoEventId)?, | ||
| scoping.organization_id, | ||
| scoping.project_id, | ||
| start_time, | ||
| retention, | ||
| Bytes::copy_from_slice(replay_event), | ||
| )?; |
There was a problem hiding this comment.
Why do we need to produce the event a second time? It's already published as part of the replay recording, right?
There was a problem hiding this comment.
Its being published to a different consumer. We're producing one event to the replay_recording consumer and another event to the replay_event consumer. The duplicated data being sent to the recording consumer for reasons other than storing the replay_event bytes. Refer to this PR #3035 where we merged the payloads.
In the future we will drop the produce_replay_event function from Relay but we're not ready yet.
Add support for replay-video event types.
Changes:
Relates to: