feat(spans): Extract additional user fields for spans #3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to bring the user fields on spans closer to transactions. User alone is not ergonomic and we'd like to be able to search by user email, username etc. Transactions also has the user's ip address but the spans table currently does not have the ipv4 and ipv6 columns for it so going to hold off on it as the other fields are more useful.
phacops
approved these changes
May 16, 2024
jjbayer
approved these changes
May 16, 2024
…xtract-additional-user-fields-for-spans
Zylphrex
added a commit
to getsentry/sentry
that referenced
this pull request
May 17, 2024
As of getsentry/relay#3599, we're now extracting a few more user related columns on spans for searching.
Zylphrex
added a commit
to getsentry/sentry
that referenced
this pull request
May 17, 2024
As of getsentry/relay#3599, we're now extracting a few more user related columns on spans for searching.
cmanallen
pushed a commit
to getsentry/sentry
that referenced
this pull request
May 21, 2024
As of getsentry/relay#3599, we're now extracting a few more user related columns on spans for searching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to bring the user fields on spans closer to transactions. User alone is not ergonomic and we'd like to be able to search by user email, username etc. Transactions also has the user's ip address but the spans table currently does not have the ipv4 and ipv6 columns for it so going to hold off on it as the other fields are more useful.