Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spans): Add more user columns to spans #71103

Merged
merged 1 commit into from
May 17, 2024

Conversation

Zylphrex
Copy link
Member

As of getsentry/relay#3599, we're now extracting a few more user related columns on spans for searching.

As of getsentry/relay#3599, we're now extracting a few more user related columns
on spans for searching.
@Zylphrex Zylphrex requested review from a team as code owners May 17, 2024 13:37
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (1491155) to head (032ed4e).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #71103      +/-   ##
==========================================
- Coverage   77.90%   77.90%   -0.01%     
==========================================
  Files        6522     6522              
  Lines      290536   290536              
  Branches    50265    50265              
==========================================
- Hits       226335   226331       -4     
- Misses      57958    57961       +3     
- Partials     6243     6244       +1     
Files Coverage Δ
src/sentry/utils/snuba.py 89.54% <ø> (ø)

... and 7 files with indirect coverage changes

@Zylphrex Zylphrex merged commit 7eb565d into master May 17, 2024
50 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/add-more-user-columns-to-spans branch May 17, 2024 14:18
cmanallen pushed a commit that referenced this pull request May 21, 2024
As of getsentry/relay#3599, we're now extracting a few more user related
columns on spans for searching.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants