feat(replays): Add denylist feature handling for replay video #3803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
approved these changes
Jul 10, 2024
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
0Calories
pushed a commit
that referenced
this pull request
Jul 11, 2024
Adds a pre-processing step to `ReplayGroup` processing. The envelope items are iterated over and if a replay-video event is found processing exits early before the items are processed. This feature should always default to enabled. It should only return the disabled state if the feature was successfully evaluated and the organization was found to be explicitly denied access. I'm not familiar with all the implications these code paths have. If someone with more knowledge and experience could double-check my work I would appreciate it. Related: getsentry/getsentry#14569 Related: getsentry/sentry#73981 --------- Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a pre-processing step to
ReplayGroupprocessing. The envelope items are iterated over and if a replay-video event is found processing exits early before the items are processed.This feature should always default to enabled. It should only return the disabled state if the feature was successfully evaluated and the organization was found to be explicitly denied access.
I'm not familiar with all the implications these code paths have. If someone with more knowledge and experience could double-check my work I would appreciate it.
Related: https://github.com/getsentry/getsentry/pull/14569
Related: getsentry/sentry#73981