feat(replays): Add mobile blocklist for sales-led orgs #73981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
c298lee
approved these changes
Jul 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #73981 +/- ##
===========================================
+ Coverage 56.65% 78.12% +21.46%
===========================================
Files 6647 6651 +4
Lines 297366 297518 +152
Branches 51174 51213 +39
===========================================
+ Hits 168480 232423 +63943
+ Misses 124271 58825 -65446
- Partials 4615 6270 +1655
|
cmanallen
added a commit
to getsentry/relay
that referenced
this pull request
Jul 10, 2024
Adds a pre-processing step to `ReplayGroup` processing. The envelope items are iterated over and if a replay-video event is found processing exits early before the items are processed. This feature should always default to enabled. It should only return the disabled state if the feature was successfully evaluated and the organization was found to be explicitly denied access. I'm not familiar with all the implications these code paths have. If someone with more knowledge and experience could double-check my work I would appreciate it. Related: getsentry/getsentry#14569 Related: getsentry/sentry#73981 --------- Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
priscilawebdev
pushed a commit
that referenced
this pull request
Jul 11, 2024
- Adds new `organizations:session-replay-video-denylist` feature. - Removes old (unused) `organizations:session-replay-video` killswitch. - Removes old (unused) denylist option.
0Calories
pushed a commit
to getsentry/relay
that referenced
this pull request
Jul 11, 2024
Adds a pre-processing step to `ReplayGroup` processing. The envelope items are iterated over and if a replay-video event is found processing exits early before the items are processed. This feature should always default to enabled. It should only return the disabled state if the feature was successfully evaluated and the organization was found to be explicitly denied access. I'm not familiar with all the implications these code paths have. If someone with more knowledge and experience could double-check my work I would appreciate it. Related: getsentry/getsentry#14569 Related: getsentry/sentry#73981 --------- Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
organizations:session-replay-video-denylistfeature.organizations:session-replay-videokillswitch.