feat: Register errorHandler inside of CanvasManager
#161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
… attributes (#160) Probably fixes getsentry/sentry-javascript#10292 Not sure how `attr.name` could be undefined here but according to the issue, it happens and we should probably guard adding the attribute.
billyvg
force-pushed
the
feat-pass-error-handler-to-canvas-manager
branch
from
4e88f4e to
07e4a5e
Compare
Needed as we (Sentry), codesplit CanvasManager. Also fixes uncaught exceptions from `createImageBitmap`
billyvg
force-pushed
the
feat-pass-error-handler-to-canvas-manager
branch
from
07e4a5e to
a67d9b9
Compare
mydea
reviewed
Jan 30, 2024
mydea
approved these changes
Jan 30, 2024
billyvg
added a commit
that referenced
this pull request
Apr 26, 2024
Needed as we (Sentry), codesplit CanvasManager. Also fixes uncaught exceptions from `createImageBitmap` --------- Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed as we (Sentry), codesplit CanvasManager. Also fixes uncaught exceptions from
createImageBitmap