fix: Catch calls to iframe content document #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mydea does it make sense to extend this to all packages in this repo? |
Yeah we probably want it for all packages |
chargome
commented
Nov 18, 2024
packages/rrweb-snapshot/src/utils.ts
Outdated
Comment on lines
462
to
470
| export function getIframeContentDocument(iframe?: HTMLIFrameElement) { | ||
| try { | ||
| if (iframe) { | ||
| return iframe.contentDocument; | ||
| } | ||
| } catch (e) { | ||
| // noop | ||
| } | ||
| } |
There was a problem hiding this comment.
duplicated it here to not create a new dependency
mydea
reviewed
Nov 18, 2024
mydea
reviewed
Nov 18, 2024
billyvg
approved these changes
Nov 18, 2024
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 5, 2024
Includes the following fixes: - fix: Catch calls to iframe content document ([#222](getsentry/rrweb#222)) - fix(snapshot): Fix CSS expansion of add CSS property ([#223](getsentry/rrweb#223))
billyvg
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Dec 6, 2024
Includes the following fixes: - fix: Catch calls to iframe content document ([#222](getsentry/rrweb#222)) - fix(snapshot): Fix CSS expansion of add CSS property ([#223](getsentry/rrweb#223))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes getsentry/sentry-javascript#14313