Skip to content

Documentation for setting the user context incorrect? #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nick-merrill opened this issue Jun 28, 2014 · 3 comments
Closed

Documentation for setting the user context incorrect? #222

nick-merrill opened this issue Jun 28, 2014 · 3 comments

Comments

@nick-merrill
Copy link

I think the documentation here may be out of date, or just incorrect.

It says that the function setUserContext({...}) exists to set the user context, but that breaks for me, while the setUser({...}) function works perfectly.

Minor issue. Sorry for the nuisance, and thanks for creating a great library!

@mattrobenolt
Copy link
Contributor

Sorry. This is the documentation for master, which has changed to the setUserContext method. I'll be trying to cut a new release this weekend to reflect this. Thanks. :)--Matt Robenolt@mattrobenolt
_____________________________From: Nick Merrill notifications@github.comSent: Saturday, June 28, 2014 13:51Subject: [raven-js] Documentation for setting the user context incorrect? (#222)To: getsentry/raven-js raven-js@noreply.github.comI think the documentation here may be out of date, or just incorrect. It says that the function setUserContext({...}) exists to set the user context, but that breaks for me, while the setUser({...}) function works perfectly. Minor issue. Sorry for the nuisance, and thanks for creating a great library! —Reply to this email directly or view it on GitHub.

@okonet
Copy link

okonet commented Sep 3, 2014

Related to #257

@mattrobenolt
Copy link
Contributor

This is fine. Both are supported in 1.1.16. setUser is being deprecated and planned to be removed in 1.2 and replaced by setUserContext.

billyvg added a commit that referenced this issue Dec 5, 2024
Includes the following fixes:

- fix: Catch calls to iframe content document ([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property ([#223](getsentry/rrweb#223))
billyvg added a commit that referenced this issue Dec 6, 2024
Includes the following fixes:

- fix: Catch calls to iframe content document
([#222](getsentry/rrweb#222))
- fix(snapshot): Fix CSS expansion of add CSS property
([#223](getsentry/rrweb#223))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants