Skip to content

Commit

Permalink
fix(react-native): Fix RN 0.75 node binary build fail (#2131)
Browse files Browse the repository at this point in the history
  • Loading branch information
krystofwoldrich authored Aug 27, 2024
1 parent 335f9bc commit 92aa676
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
!package.json
!README.md
!LICENSE
!bin
!bin/sentry-cli
!js
!scripts/install.js
!checksums.txt
Expand Down
19 changes: 19 additions & 0 deletions bin/sentry-cli-dev
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#!/usr/bin/env node

'use strict';

const childProcess = require('child_process');
const path = require('path');

const child = childProcess
.spawn(path.join(__dirname, '../target/debug/sentry-cli'), process.argv.slice(2), {
stdio: 'inherit',
})
.on('error', (err) => {
console.error(err); // eslint-disable-line no-console
process.exit(1);
})
.on('exit', (code) => process.exit(code));

process.on('SIGTERM', () => child.kill('SIGTERM'));
process.on('SIGINT', () => child.kill('SIGINT'));
1 change: 0 additions & 1 deletion src/commands/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ fn preexecute_hooks() -> Result<bool> {
#[cfg(target_os = "macos")]
fn sentry_react_native_xcode_wrap() -> Result<bool> {
if let Ok(val) = env::var("__SENTRY_RN_WRAP_XCODE_CALL") {
env::remove_var("__SENTRY_RN_WRAP_XCODE_CALL");
if &val == "1" {
crate::commands::react_native::xcode::wrap_call()?;
return Ok(true);
Expand Down

0 comments on commit 92aa676

Please sign in to comment.