Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-native): Fix RN 0.75 node binary build fail #2131

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Aug 26, 2024

The change enables wrapped call to execute other child calls.

This is need due to recent RN 0.75 change.

sentry-cli-fake-node react-native/cli.js config is called by sentry-cli-fake-node @react-native-community/cli bundle

For this we need to allow the recursive wrapped calls. This is currently not an issue as the wrapped call doesn't execute Sentry-CLI binary commands.


The added [sentry-cli-dev](https://github.com/getsentry/sentry-cli/pull/2131/files#diff-03f1f612bbc5cf7f68294e8711ae18b595e02639a86cf9c3c4e633576ca1836c) makes testing dev build easier in node environments.

@krystofwoldrich krystofwoldrich merged commit 92aa676 into master Aug 27, 2024
14 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/fix-rn-0-75 branch August 27, 2024 14:32
This was referenced Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOS build: Sentry fails with RN 0.75
2 participants