Fix new clippy lints #2096
Merged
Fix new clippy lints #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the newer compiler version is more aggressive detecting dead code, and flags a bunch of fields/functions as unused. Some of those are behind feature flags, others might legitimately be unused. However, I just used an `allow` to quickly unblock other PRs that are failing because of these lints without digging deeper. Also ran a `cargo update` for good measure, but not bumping any semver-major dependency versions.
szokeasaurusrex
approved these changes
Jul 3, 2024
loewenheim
approved these changes
Jul 3, 2024
szokeasaurusrex
added a commit
that referenced
this pull request
Jul 22, 2024
This reverts commit 9cf9afb.
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 5, 2024
We added a blanket `allow(dead_code)` for the entire api module in #2096 because of some new clippy lints which were failing. Here, we remove the blanket `allow(dead_code)` and only allow dead code for the specific lines where it occurs. It might not be possible to remove these because serde might rely on their presence.
szokeasaurusrex
added a commit
that referenced
this pull request
Nov 5, 2024
We added a blanket `allow(dead_code)` for the entire api module in #2096 because of some new clippy lints which were failing. Here, we remove the blanket `allow(dead_code)` and only expect dead code for the specific lines where it occurs. It might not be possible to remove these because serde might rely on their presence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the newer compiler version is more aggressive detecting dead code, and flags a bunch of fields/functions as unused. Some of those are behind feature flags, others might legitimately be unused. However, I just used an
allowto quickly unblock other PRs that are failing because of these lints without digging deeper.Also ran a
cargo updatefor good measure, but not bumping any semver-major dependency versions.