ref(api): Only allow dead code where needed

[szokeasaurusrex]

We added a blanket allow(dead_code) for the entire api module in #2096 because of some new clippy lints which were failing.

Here, we remove the blanket allow(dead_code) and only allow dead code for the specific lines where it occurs. It might not be possible to remove these because serde might rely on their presence.

[loewenheim]

AFAICT all of these types are only Deserialize. In that case it should be fine to remove the unused fields. serde will happily deserialize types from inputs that have "too many" fields, unless you use deny_unknown_fields.

See https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=7b4171977ebcc5aa60503a6a1c6b87c1

[loewenheim]

Also, if you do want to keep them, it might make sense to use #[expect(dead_code)] instead of #[allow(dead_code)], which was added a few versions ago. The difference is that with expect there is a warning if the lint doesn't trigger. This makes sure the field actually isn't used.

[szokeasaurusrex]

@loewenheim let's keep the unused fields in case removing them has some unintended side effects. Keeping them around is lower risk than removing them.

I applied your suggestion to use expect rather than allow. Might be worth changing this throughout the codebase.

[loewenheim]

I applied your suggestion to use expect rather than allow. Might be worth changing this throughout the codebase.

I agree, I think in most cases where we used to use allow we actually want expect, but it didn't exist.