Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetricKit MXDiagnosticPayload GA #2585

Closed
8 tasks done
philipphofmann opened this issue Jan 9, 2023 · 1 comment · Fixed by #3340
Closed
8 tasks done

MetricKit MXDiagnosticPayload GA #2585

philipphofmann opened this issue Jan 9, 2023 · 1 comment · Fixed by #3340
Assignees
@philipphofmann
Labels
Platform: Cocoa

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Jan 9, 2023 •
edited
Loading

Description

Experimental initial issue: #1661

Items to complete for making the MetricKit integration GA:

Tasks
Beta Give feedback
  3. Fix inApp for MetricKit stacktraces #2738
    Status: Backlog Type: Bug
    philipphofmann
  4. MXHangDiagnostic missing code_file #2846
    Platform: Cocoa Type: Bug
  5. MetricKit ignore stacktraces from the SDK #2847
    Platform: Cocoa
    philipphofmann
  7. feat(apple): MetricKit GA sentry-docs#8186
@github-project-automation github-project-automation bot moved this to Needs Discussion in Mobile & Cross Platform SDK Jan 9, 2023
@philipphofmann philipphofmann moved this from Needs Discussion to In Progress in Mobile & Cross Platform SDK Jan 18, 2023
@philipphofmann philipphofmann self-assigned this Jan 18, 2023
@philipphofmann philipphofmann moved this from In Progress to Needs Validation in Mobile & Cross Platform SDK Mar 29, 2023
@philipphofmann philipphofmann moved this from Needs Validation to Backlog in Mobile & Cross Platform SDK Jun 14, 2023
@philipphofmann philipphofmann removed their assignment Jul 21, 2023
@philipphofmann philipphofmann moved this from Backlog to In Progress in Mobile & Cross Platform SDK Oct 12, 2023
@philipphofmann philipphofmann self-assigned this Oct 12, 2023
philipphofmann added a commit that referenced this issue Oct 12, 2023
@philipphofmann
feat: GA MetricKit integration
612ec4f 
Remove experimental note on options to make the MetricKit
integration GA.

Fixes GH-2585
@philipphofmann philipphofmann mentioned this issue Oct 12, 2023
Merged
7 tasks
@philipphofmann
Copy link
Member Author

We completed all items to make the MetricKit integration GA.

One blocker was that the integration also reports issues of the Cocoa SDK. I documented my reasoning for not doing that here #2847 (comment):

After some investigation in #3176, we can conclude that doing this reliably on the client side is complicated. We could discard such events on the backend, but then we kind of lie. If MetricKit detects an issue inside our SDK we shouldn't discard the issue, but report it. We can collect such issues alongside with our SDK crashes and try to fix them: getsentry/sentry#57961.

philipphofmann added a commit that referenced this issue Oct 12, 2023
@philipphofmann
feat: GA MetricKit integration (#3340)
2affdbd 
Remove experimental note on options to make the MetricKit
integration GA.

Fixes GH-2585
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mobile & Cross Platform SDK Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipphofmann philipphofmann

Labels
Platform: Cocoa
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: GA MetricKit integration getsentry/sentry-cocoa
3 participants
@kahest @philipphofmann @hubertdeng123