Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple): MetricKit GA #8186

Merged
merged 9 commits into from
Oct 18, 2023
Merged

feat(apple): MetricKit GA #8186

merged 9 commits into from
Oct 18, 2023

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Oct 12, 2023

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Remove experimental note and add some info on MetricKit events.

Only merge this PR after releasing Cocoa 8.14.0.

Remove experimental note and add some info on MetricKit events.
@philipphofmann philipphofmann requested a review from a team as a code owner October 12, 2023 11:22
@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 2:29pm

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks Philipp!
left small wording suggestions

src/platforms/apple/common/configuration/metric-kit.mdx Outdated Show resolved Hide resolved
src/platforms/apple/common/configuration/metric-kit.mdx Outdated Show resolved Hide resolved
philipphofmann and others added 2 commits October 12, 2023 15:33
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few language suggestions. Also, would it be possible to change the title of this section from "Metric Kit" to "MetricKit" to match how it's written in the world? :)

src/platforms/apple/common/configuration/metric-kit.mdx Outdated Show resolved Hide resolved
src/platforms/apple/common/configuration/metric-kit.mdx Outdated Show resolved Hide resolved
src/platforms/apple/common/configuration/metric-kit.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one spelling fix. LGTM!

src/platforms/apple/common/configuration/metric-kit.mdx Outdated Show resolved Hide resolved
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
@kahest kahest merged commit e3fc662 into master Oct 18, 2023
7 checks passed
@kahest kahest deleted the feat/metric-kit-ga branch October 18, 2023 16:56
@philipphofmann
Copy link
Member Author

Thanks for merging this, @kahest.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants