-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apple): MetricKit GA #8186
Conversation
Remove experimental note and add some info on MetricKit events.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 thanks Philipp!
left small wording suggestions
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few language suggestions. Also, would it be possible to change the title of this section from "Metric Kit" to "MetricKit" to match how it's written in the world? :)
Co-authored-by: Liza Mock <liza.mock@sentry.io>
Co-authored-by: Liza Mock <liza.mock@sentry.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one spelling fix. LGTM!
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Thanks for merging this, @kahest. |
Pre-merge checklist
If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.
Description of changes
Remove experimental note and add some info on MetricKit events.
Only merge this PR after releasing Cocoa 8.14.0.