Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SentryFramesTracker recordTimestamp:value:array:] #3511

Closed
zhou934381967 opened this issue Dec 19, 2023 · 5 comments · Fixed by #3571
Closed

[SentryFramesTracker recordTimestamp:value:array:] #3511

zhou934381967 opened this issue Dec 19, 2023 · 5 comments · Fixed by #3571
Assignees
@philipphofmann
Labels
Platform: Cocoa Type: Bug

Comments

@zhou934381967
Copy link

Platform

iOS

Environment

Production

Installed

Swift Package Manager

Version

8.9.6

Did it work on previous versions?

No response

Steps to Reproduce

Direct use will appear.

Expected Result

no crash.

Actual Result

Have a Crash.
截屏2023-12-19 13 55 55

Are you willing to submit a PR?

No response
@philipphofmann
Copy link
Member

Thanks again @zhou934381967. Internal SDK crashes reference.

@zhou934381967
Copy link
Author

Authentication error: The domain for your Google account (gmail.com) is not allowed to authenticate with this provider. Yes You cannot view the internal SDK crashes.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Dec 20, 2023
@kahest
Copy link
Member

kahest commented Dec 20, 2023

@zhou934381967 This is intended, it's a Sentry internal resource with additional context for this issue - you will not be able to open this.

@getsantry getsantry bot removed the status in GitHub Issues with 👀 Dec 20, 2023
@philipphofmann philipphofmann moved this from Needs Discussion to Todo in Mobile & Cross Platform SDK Jan 3, 2024
@zhou934381967
Copy link
Author

Has the problem been solved?

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Jan 10, 2024
@philipphofmann
Copy link
Member

@zhou934381967, no we didn't fix the issue yet.

@philipphofmann philipphofmann moved this from Todo to In Progress in Mobile & Cross Platform SDK Jan 23, 2024
@philipphofmann philipphofmann self-assigned this Jan 23, 2024
philipphofmann added a commit that referenced this issue Jan 23, 2024
@philipphofmann
fix: Synchronization issue in FramesTracker
059670b 
Synchronize the call to SentryFramesTracker.resetProfilingTimestamps by
dispatching it to the main thread cause there is no guarantee that the
SDK calls this method on the main thread. Previously, this issue led to
crashes in SentryFramesTracker.

Fixes GH-3511
@philipphofmann philipphofmann mentioned this issue Jan 23, 2024
Merged
7 tasks
philipphofmann added a commit that referenced this issue Jan 29, 2024
@philipphofmann
fix: Synchronization issue in FramesTracker (#3571)
eef4553 
* fix: Synchronization issue in FramesTracker

Synchronize the call to SentryFramesTracker.resetProfilingTimestamps by
dispatching it to the main thread cause there is no guarantee that the
SDK calls this method on the main thread. Previously, this issue led to
crashes in SentryFramesTracker.

Fixes GH-3511
@github-project-automation github-project-automation bot moved this from In Progress to Done in Mobile & Cross Platform SDK Jan 29, 2024
@philipphofmann philipphofmann mentioned this issue Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipphofmann philipphofmann

Labels
Platform: Cocoa Type: Bug
Projects
GitHub Issues with 👀
Archived in project
GitHub Issues with 👀 2
Archived in project
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Synchronization issue in FramesTracker getsentry/sentry-cocoa
3 participants
@kahest @philipphofmann @zhou934381967