-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Synchronization issue in FramesTracker #3571
Conversation
Synchronize the call to SentryFramesTracker.resetProfilingTimestamps by dispatching it to the main thread cause there is no guarantee that the SDK calls this method on the main thread. Previously, this issue led to crashes in SentryFramesTracker. Fixes GH-3511
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3571 +/- ##
=============================================
+ Coverage 89.262% 89.269% +0.006%
=============================================
Files 529 529
Lines 57716 57752 +36
Branches 20653 20669 +16
=============================================
+ Hits 51519 51555 +36
- Misses 5287 5288 +1
+ Partials 910 909 -1
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e324230 | 1244.43 ms | 1252.98 ms | 8.55 ms |
d760c3f | 1200.95 ms | 1233.96 ms | 33.00 ms |
5d6ce0e | 1227.57 ms | 1241.08 ms | 13.51 ms |
7cd187e | 1223.41 ms | 1249.40 ms | 26.00 ms |
407ff99 | 1216.63 ms | 1235.50 ms | 18.87 ms |
dc0db9e | 1246.06 ms | 1260.46 ms | 14.40 ms |
881a955 | 1230.98 ms | 1246.22 ms | 15.24 ms |
98cca71 | 1210.75 ms | 1240.64 ms | 29.89 ms |
9faf217 | 1268.86 ms | 1274.82 ms | 5.96 ms |
e1eed6b | 1224.63 ms | 1234.84 ms | 10.20 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e324230 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
d760c3f | 22.84 KiB | 403.17 KiB | 380.33 KiB |
5d6ce0e | 22.85 KiB | 405.38 KiB | 382.53 KiB |
7cd187e | 20.76 KiB | 401.66 KiB | 380.89 KiB |
407ff99 | 20.76 KiB | 427.87 KiB | 407.10 KiB |
dc0db9e | 20.76 KiB | 419.62 KiB | 398.86 KiB |
881a955 | 22.85 KiB | 407.63 KiB | 384.79 KiB |
98cca71 | 22.85 KiB | 411.14 KiB | 388.29 KiB |
9faf217 | 20.76 KiB | 419.70 KiB | 398.94 KiB |
e1eed6b | 20.76 KiB | 432.17 KiB | 411.41 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tvOS tests are failing, everything else LGTM
📜 Description
Synchronize the call to SentryFramesTracker.resetProfilingTimestamps by dispatching it to the main thread cause there is no guarantee that the SDK calls this method on the main thread. Previously, this issue led to crashes in SentryFramesTracker.
💡 Motivation and Context
Fixes GH-3511
💚 How did you test it?
Unit test.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps