-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Track usage of the enableCaptureFailedRequests option #2368
Merged
kevinrenskers
merged 3 commits into
master
from
feature/2354-track-enableCaptureFailedRequests
Nov 8, 2022
Merged
feat: Track usage of the enableCaptureFailedRequests option #2368
kevinrenskers
merged 3 commits into
master
from
feature/2354-track-enableCaptureFailedRequests
Nov 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinrenskers
requested review from
philipphofmann,
brustolin and
armcknight
as code owners
November 7, 2022 12:41
|
kevinrenskers
commented
Nov 7, 2022
philipphofmann
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kevinrenskers.
philipphofmann
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kevinrenskers
deleted the
feature/2354-track-enableCaptureFailedRequests
branch
November 8, 2022 10:04
philipphofmann
added a commit
that referenced
this pull request
Nov 8, 2022
kevinrenskers
added a commit
that referenced
this pull request
Nov 9, 2022
* master: chore: Add match_local to Fastfile Revert "feat: Track usage of the enableCaptureFailedRequests option (#2368)" (#2371) chore: Remove PrivateSentrySDKOnly.h from umbrella header (#2349) feat: Track usage of the enableCaptureFailedRequests option (#2368) Update SentryNetworkTrackerIntegrationTests.swift (#2366) Fix typos in NetworkTrackerIntegrationTests (#2367) build(deps): bump github/codeql-action from 2.1.30 to 2.1.31 (#2364)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
We can now report usage of the enableCaptureFailedRequests option, as an integration.
(Very similar to #2281.)
💡 Motivation and Context
Closes #2354
💚 How did you test it?
Unit test
📝 Checklist
🔮 Next steps