Revert "feat: Track usage of the enableCaptureFailedRequests option" #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I’ll forgive you in return for a review for #2347 :p
|
kevinrenskers
approved these changes
Nov 8, 2022
| @@ -416,7 +416,7 @@ NS_SWIFT_NAME(Options) | |||
|
|
|||
| /** | |||
| * When enabled, the SDK captures HTTP Client errors. Default value is NO. | |||
| * This feature requires enableSwizzling enabled as well, default value is YES. | |||
| * This feature requires enableSwizzling enabled as well, Default value is YES. | |||
There was a problem hiding this comment.
I'd keep this though.
philipphofmann
deleted the
revert-2368-feature/2354-track-enableCaptureFailedRequests
branch
kevinrenskers
added a commit
that referenced
this pull request
Nov 9, 2022
* master: chore: Add match_local to Fastfile Revert "feat: Track usage of the enableCaptureFailedRequests option (#2368)" (#2371) chore: Remove PrivateSentrySDKOnly.h from umbrella header (#2349) feat: Track usage of the enableCaptureFailedRequests option (#2368) Update SentryNetworkTrackerIntegrationTests.swift (#2366) Fix typos in NetworkTrackerIntegrationTests (#2367) build(deps): bump github/codeql-action from 2.1.30 to 2.1.31 (#2364)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2368
We can already track this in Looker with the mechanism type
sentry-cocoa/Sources/Sentry/SentryNetworkTracker.m
Line 339 in 59afa00
Sorry about that, @kevinrenskers. We can undo this PR. No need to send the data twice.
#skip-changelog