Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add/improve logging #2420

Merged
merged 1 commit into from
Nov 22, 2022
Merged

meta: add/improve logging #2420

merged 1 commit into from
Nov 22, 2022

Conversation

armcknight
Copy link
Member

I accumulated a lot of added logs while debugging another branch so wanted to separate these out into a separate PR to cut down the noise in the other one (#2228)

#skip-changelog

@github-actions
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.39 ms 1252.64 ms 18.25 ms
Size 20.75 KiB 383.08 KiB 362.32 KiB

Baseline results on branch: master

Startup times

Revision Plain With Sentry Diff
1453a8a 1204.22 ms 1230.84 ms 26.61 ms
d975745 1215.47 ms 1248.90 ms 33.43 ms
604586a 1216.06 ms 1249.10 ms 33.04 ms
8607e67 1255.80 ms 1259.50 ms 3.70 ms
4a66f00 1259.84 ms 1281.66 ms 21.82 ms
0fdf0b2 1194.37 ms 1227.90 ms 33.53 ms
d883642 1215.39 ms 1242.78 ms 27.39 ms
e2a3f3e 1230.65 ms 1247.06 ms 16.41 ms
864c39a 1239.45 ms 1256.76 ms 17.31 ms
7c867f1 1206.16 ms 1234.88 ms 28.71 ms

App size

Revision Plain With Sentry Diff
1453a8a 20.50 KiB 361.89 KiB 341.39 KiB
d975745 20.75 KiB 374.73 KiB 353.97 KiB
604586a 20.51 KiB 333.15 KiB 312.65 KiB
8607e67 20.50 KiB 338.99 KiB 318.49 KiB
4a66f00 20.51 KiB 331.79 KiB 311.28 KiB
0fdf0b2 20.51 KiB 332.90 KiB 312.39 KiB
d883642 20.50 KiB 338.99 KiB 318.49 KiB
e2a3f3e 20.75 KiB 368.01 KiB 347.26 KiB
864c39a 20.51 KiB 335.57 KiB 315.06 KiB
7c867f1 20.51 KiB 332.59 KiB 312.09 KiB

@philipphofmann philipphofmann changed the base branch from master to 8.0.0 November 22, 2022 07:09
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🙏

@philipphofmann philipphofmann merged commit e2cec76 into 8.0.0 Nov 22, 2022
@philipphofmann philipphofmann deleted the armcknight/meta/logging branch November 22, 2022 12:39
kevinrenskers added a commit that referenced this pull request Nov 22, 2022
* 8.0.0:
  ref: Fix typos in OOMTracker (#2431)
  ref: Make SpanProtocol.data non nullable (#2409)
  ref: add/improve logging (#2420)
  ref: bump supported OS versions (#2414)
  test: shorten some tests (#2428)
  ref: Remove `- [SentryOptions initWithDict:didFailWithError:]` (#2404)
  ref: Mark [SpanProtocol setExtraValue:forKey] as deprecated (#2413)
  typos (#2421)
  test: Disable NSDataTracker in clearTestState (#2418)
  Update CHANGELOG.md (#2415)
  feat: Properly demangle Swift class name (#2162)
  chore: Create 8.0.0 branch
  test: include Sentry changes in hash keys (#2412)
  release: 7.31.2
  fix: Crash in Client when reading integrations (#2398)
  test: tooling improvements (#2400)
  fix: Don't increase session's error count for dropped events (#2374)
  Update CHANGELOG.md (#2396)
  release: 7.31.1
  Fix: Set the correct OOM event timestamp (#2394)

# Conflicts:
#	Sentry.xcodeproj/project.pbxproj
#	SentryPrivate.podspec
#	scripts/add-sentry-to-vlc.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants