Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: include Sentry changes in hash keys #2412

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

armcknight
Copy link
Member

Previously, test apps that link in compiled Sentry sources weren't getting rebuilt even if the sentry sources changed.

#skip-changelog

@github-actions
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1191.54 ms 1235.78 ms 44.24 ms
Size 20.75 KiB 374.73 KiB 353.97 KiB

Baseline results on branch: master

Startup times

Revision Plain With Sentry Diff
604586a 1216.06 ms 1249.10 ms 33.04 ms
d73ebd0 1200.83 ms 1236.10 ms 35.27 ms
8607e67 1255.80 ms 1259.50 ms 3.70 ms
075911d 1256.73 ms 1271.22 ms 14.49 ms
cd8dad3 1227.90 ms 1240.56 ms 12.66 ms
f444dc4 1242.55 ms 1248.82 ms 6.27 ms
0e2e593 1234.78 ms 1266.10 ms 31.32 ms
e43ce74 1235.77 ms 1252.06 ms 16.29 ms
8607e67 1213.53 ms 1238.20 ms 24.67 ms
ee127f4 1203.49 ms 1231.28 ms 27.79 ms

App size

Revision Plain With Sentry Diff
604586a 20.51 KiB 333.15 KiB 312.65 KiB
d73ebd0 20.50 KiB 365.18 KiB 344.68 KiB
8607e67 20.50 KiB 338.99 KiB 318.49 KiB
075911d 20.51 KiB 332.90 KiB 312.39 KiB
cd8dad3 20.75 KiB 374.17 KiB 353.41 KiB
f444dc4 20.75 KiB 367.00 KiB 346.25 KiB
0e2e593 20.50 KiB 333.88 KiB 313.38 KiB
e43ce74 20.51 KiB 335.49 KiB 314.99 KiB
8607e67 20.50 KiB 338.99 KiB 318.49 KiB
ee127f4 20.51 KiB 333.10 KiB 312.59 KiB

@armcknight armcknight merged commit 48c7211 into master Nov 19, 2022
@armcknight armcknight deleted the armcknight/fix/test-app-caching branch November 19, 2022 00:41
kevinrenskers added a commit that referenced this pull request Nov 21, 2022
* 8.0.0:
  Update CHANGELOG.md (#2415)
  feat: Properly demangle Swift class name (#2162)
  chore: Create 8.0.0 branch
  test: include Sentry changes in hash keys (#2412)
  release: 7.31.2
@philipphofmann
Copy link
Member

Thanks, @armcknight.

kevinrenskers added a commit that referenced this pull request Nov 22, 2022
* 8.0.0:
  ref: Fix typos in OOMTracker (#2431)
  ref: Make SpanProtocol.data non nullable (#2409)
  ref: add/improve logging (#2420)
  ref: bump supported OS versions (#2414)
  test: shorten some tests (#2428)
  ref: Remove `- [SentryOptions initWithDict:didFailWithError:]` (#2404)
  ref: Mark [SpanProtocol setExtraValue:forKey] as deprecated (#2413)
  typos (#2421)
  test: Disable NSDataTracker in clearTestState (#2418)
  Update CHANGELOG.md (#2415)
  feat: Properly demangle Swift class name (#2162)
  chore: Create 8.0.0 branch
  test: include Sentry changes in hash keys (#2412)
  release: 7.31.2
  fix: Crash in Client when reading integrations (#2398)
  test: tooling improvements (#2400)
  fix: Don't increase session's error count for dropped events (#2374)
  Update CHANGELOG.md (#2396)
  release: 7.31.1
  Fix: Set the correct OOM event timestamp (#2394)

# Conflicts:
#	Sentry.xcodeproj/project.pbxproj
#	SentryPrivate.podspec
#	scripts/add-sentry-to-vlc.patch
kevinrenskers added a commit that referenced this pull request Nov 24, 2022
* master: (56 commits)
  meta: disable swiftlint file length check in TBDBClient.swift (#2435)
  Revert "test: shorten some tests (#2422)" (#2427)
  test: shorten some tests (#2422)
  test: include Sentry changes in hash keys (#2412)
  release: 7.31.2
  fix: Crash in Client when reading integrations (#2398)
  test: tooling improvements (#2400)
  fix: Don't increase session's error count for dropped events (#2374)
  Update CHANGELOG.md (#2396)
  release: 7.31.1
  Fix: Set the correct OOM event timestamp (#2394)
  test: Fix SentrySerializationTests.testSerializationFailsWithInvalidJSONObject (#2392)
  feat(hybrid-sdks): Add captureScreenshots to PrivateSDKOnly (#2384)
  ci: Increase test timeout for iOS 12 (#2391)
  test: Disable flaky testCrashReportCount1 (#2389)
  test: Disable flaky testSerializeWithUnderlyingNSException (#2387)
  build(deps): bump github/codeql-action from 2.1.31 to 2.1.32 (#2386)
  build(deps): bump fastlane from 2.210.1 to 2.211.0 (#2385)
  ref: json serialization error reporting (#2355)
  release: 7.31.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants