test: shorten some tests #2422
Merged
test: shorten some tests #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcknight
requested review from
philipphofmann and
brustolin
as code owners
philipphofmann
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
LGTM. Should be fine. It's only for finding threading issues, I guess. The test suite should be fast. I think we don't need a nightly. We also have the thread sanitizer, which detects threading issues
sentry-cocoa/.github/workflows/test.yml
Line 210 in 48c7211
philipphofmann
added a commit
that referenced
this pull request
Nov 22, 2022
This reverts commit 189472a.
philipphofmann
added a commit
that referenced
this pull request
Nov 22, 2022
kevinrenskers
added a commit
that referenced
this pull request
Nov 24, 2022
* master: (56 commits) meta: disable swiftlint file length check in TBDBClient.swift (#2435) Revert "test: shorten some tests (#2422)" (#2427) test: shorten some tests (#2422) test: include Sentry changes in hash keys (#2412) release: 7.31.2 fix: Crash in Client when reading integrations (#2398) test: tooling improvements (#2400) fix: Don't increase session's error count for dropped events (#2374) Update CHANGELOG.md (#2396) release: 7.31.1 Fix: Set the correct OOM event timestamp (#2394) test: Fix SentrySerializationTests.testSerializationFailsWithInvalidJSONObject (#2392) feat(hybrid-sdks): Add captureScreenshots to PrivateSDKOnly (#2384) ci: Increase test timeout for iOS 12 (#2391) test: Disable flaky testCrashReportCount1 (#2389) test: Disable flaky testSerializeWithUnderlyingNSException (#2387) build(deps): bump github/codeql-action from 2.1.31 to 2.1.32 (#2386) build(deps): bump fastlane from 2.210.1 to 2.211.0 (#2385) ref: json serialization error reporting (#2355) release: 7.31.0 ...
kevinrenskers
added a commit
that referenced
this pull request
Nov 29, 2022
* 8.0.0: Merge branch 'master' into 8.0.0 release: 7.31.3 revert rename of sentryuser (#2462) fix: Reporting crashes when restarting the SDK (#2440) Update integration-tests.yml (#2461) fix: Core data span status with error (#2439) meta: disable swiftlint file length check in TBDBClient.swift (#2435) Revert "test: shorten some tests (#2422)" (#2427) test: shorten some tests (#2422) # Conflicts: # Tests/SentryTests/Helper/TestNSNotificationCenterWrapper.swift
kevinrenskers
added a commit
that referenced
this pull request
Nov 29, 2022
…ERSIZE * 8.0.0: fix: SentryAppStateManager should always stop when closing the SDK (#2460) Merge branch 'master' into 8.0.0 release: 7.31.3 fix: Reporting crashes when restarting the SDK (#2440) Update integration-tests.yml (#2461) fix: Core data span status with error (#2439) meta: disable swiftlint file length check in TBDBClient.swift (#2435) Revert "test: shorten some tests (#2422)" (#2427) test: shorten some tests (#2422)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making various refactorings (for #2228) and running tests locally, there were a few that ran really slowly.
How do we feel about shortening these loops, and then if we want something like a stress test suite that runs nightly or post-merge, do it separately there?
#skip-changelog