-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: compile out more code from macOS builds that only works for UIKit #3157
ref: compile out more code from macOS builds that only works for UIKit #3157
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3157 +/- ##
=============================================
- Coverage 89.139% 89.102% -0.037%
=============================================
Files 502 502
Lines 53977 53904 -73
Branches 19332 19311 -21
=============================================
- Hits 48115 48030 -85
- Misses 4894 5019 +125
+ Partials 968 855 -113
... and 29 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
fc163f5 | 1198.05 ms | 1227.76 ms | 29.71 ms |
1bbcb9c | 1192.51 ms | 1231.96 ms | 39.45 ms |
c0b4b71 | 1246.98 ms | 1256.77 ms | 9.79 ms |
90d17d3 | 1261.18 ms | 1278.18 ms | 17.00 ms |
eed479f | 1198.93 ms | 1228.12 ms | 29.19 ms |
ff09c7e | 1244.86 ms | 1246.68 ms | 1.82 ms |
154f795 | 1250.38 ms | 1274.54 ms | 24.16 ms |
369222e | 1232.14 ms | 1258.90 ms | 26.76 ms |
596ccc1 | 1221.57 ms | 1236.82 ms | 15.25 ms |
591a01b | 1197.94 ms | 1222.53 ms | 24.59 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
fc163f5 | 20.76 KiB | 436.30 KiB | 415.54 KiB |
1bbcb9c | 20.76 KiB | 426.10 KiB | 405.34 KiB |
c0b4b71 | 20.76 KiB | 430.98 KiB | 410.22 KiB |
90d17d3 | 20.76 KiB | 432.17 KiB | 411.41 KiB |
eed479f | 20.76 KiB | 433.18 KiB | 412.42 KiB |
ff09c7e | 20.76 KiB | 427.77 KiB | 407.00 KiB |
154f795 | 20.76 KiB | 435.25 KiB | 414.49 KiB |
369222e | 20.76 KiB | 419.67 KiB | 398.91 KiB |
596ccc1 | 22.84 KiB | 401.44 KiB | 378.60 KiB |
591a01b | 22.84 KiB | 401.67 KiB | 378.83 KiB |
Previous results on branch: armcknight/ref/compile-out-more-SENTRY_HAS_UIKIT
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e929c27 | 1244.80 ms | 1253.02 ms | 8.22 ms |
fe98a1e | 1205.94 ms | 1226.60 ms | 20.66 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e929c27 | 22.84 KiB | 403.21 KiB | 380.37 KiB |
fe98a1e | 22.84 KiB | 403.18 KiB | 380.34 KiB |
…e-out-more-SENTRY_HAS_UIKIT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. As this reduces the SDK size for macOS by 2% we could add an entry to the changelog under an improvement section.
9bdceb3
to
e0a817c
Compare
True that! Gotta take the opportunity to brag whenever possible :) |
Broken by getsentry/sentry-cocoa#3157 (v8.9.2) because the `SentryAppStartMeasurement` is not exported anymore.
📜 Description
Compile out more class (and their imports) that are for features that only work with UIKit.
💡 Motivation and Context
Improves type safety, reduces the size of the maOS SDK by 2% (~101 KB) and runs slightly fewer tests for macOS.
#skip-changelog