-
-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: compile out more code not supported in watchOS #3161
ref: compile out more code not supported in watchOS #3161
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3161 +/- ##
=========================================
Coverage 89.089% 89.089%
=========================================
Files 502 502
Lines 53839 53877 +38
Branches 19300 19315 +15
=========================================
+ Hits 47965 47999 +34
- Misses 4906 4909 +3
- Partials 968 969 +1
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
adcc7d8 | 1225.90 ms | 1245.08 ms | 19.18 ms |
fb53d97 | 1226.08 ms | 1245.12 ms | 19.04 ms |
005bb4c | 1237.38 ms | 1255.54 ms | 18.16 ms |
7fb7afb | 1230.12 ms | 1251.04 ms | 20.92 ms |
2af280d | 1226.46 ms | 1229.81 ms | 3.35 ms |
904d7fa | 1225.73 ms | 1249.22 ms | 23.49 ms |
fd6a31c | 1190.43 ms | 1218.78 ms | 28.35 ms |
98a8c16 | 1243.33 ms | 1257.86 ms | 14.53 ms |
60dd0f5 | 1244.96 ms | 1268.98 ms | 24.02 ms |
32e64d1 | 6272.19 ms | 6299.50 ms | 27.31 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
adcc7d8 | 20.76 KiB | 426.15 KiB | 405.39 KiB |
fb53d97 | 20.76 KiB | 425.81 KiB | 405.04 KiB |
005bb4c | 20.76 KiB | 419.70 KiB | 398.94 KiB |
7fb7afb | 20.76 KiB | 419.70 KiB | 398.94 KiB |
2af280d | 20.76 KiB | 435.22 KiB | 414.46 KiB |
904d7fa | 20.76 KiB | 432.87 KiB | 412.11 KiB |
fd6a31c | 20.76 KiB | 436.50 KiB | 415.74 KiB |
98a8c16 | 20.76 KiB | 431.00 KiB | 410.24 KiB |
60dd0f5 | 20.76 KiB | 393.36 KiB | 372.60 KiB |
32e64d1 | 20.76 KiB | 433.18 KiB | 412.42 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Same as #3157, #3158 and #3159: remove a bit more code from watch targets/tests.
#skip-changelog