Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Convert ANRV2Delegate to Swift #4285

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

philipphofmann
Copy link
Member

It's always better to have more code in Swift.

#skip-changelog

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.654%. Comparing base (279351b) to head (2f31d34).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4285       +/-   ##
=============================================
+ Coverage   91.580%   91.654%   +0.074%     
=============================================
  Files          616       617        +1     
  Lines        50096     50184       +88     
  Branches     18015     18109       +94     
=============================================
+ Hits         45878     45996      +118     
+ Misses        4125      4095       -30     
  Partials        93        93               

see 19 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279351b...2f31d34. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1238.47 ms 1251.43 ms 12.96 ms
Size 21.58 KiB 706.63 KiB 685.05 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e84bc3f 1201.49 ms 1232.82 ms 31.33 ms
e072ad1 1232.43 ms 1245.51 ms 13.08 ms
6c31077 1233.80 ms 1245.34 ms 11.54 ms
e1cd9e9 1190.64 ms 1221.90 ms 31.26 ms
25737cb 1235.02 ms 1250.06 ms 15.04 ms
c00eafe 1198.26 ms 1227.62 ms 29.36 ms
94e1968 1234.41 ms 1252.63 ms 18.22 ms
a7ca2d1 1237.42 ms 1248.98 ms 11.56 ms
cf724da 1226.61 ms 1235.70 ms 9.09 ms
881a955 1222.94 ms 1246.26 ms 23.32 ms

App size

Revision Plain With Sentry Diff
e84bc3f 20.76 KiB 434.72 KiB 413.96 KiB
e072ad1 21.58 KiB 625.83 KiB 604.24 KiB
6c31077 22.84 KiB 401.65 KiB 378.81 KiB
e1cd9e9 22.85 KiB 412.95 KiB 390.10 KiB
25737cb 20.76 KiB 436.29 KiB 415.53 KiB
c00eafe 20.76 KiB 432.87 KiB 412.11 KiB
94e1968 21.58 KiB 614.74 KiB 593.15 KiB
a7ca2d1 21.58 KiB 614.92 KiB 593.34 KiB
cf724da 20.76 KiB 430.52 KiB 409.76 KiB
881a955 22.85 KiB 407.63 KiB 384.78 KiB

@philipphofmann philipphofmann merged commit 35647ef into main Aug 16, 2024
65 checks passed
@philipphofmann philipphofmann deleted the ref/convert-anrv2delegate-to-swift branch August 16, 2024 08:02
@philipphofmann philipphofmann self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants