-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Support for non-fully-blocking app hangs #4286
Conversation
Add the logic for non-fully-blocking app hangs when the frame delay exceeds 99%. This is required for GH-3492.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4286 +/- ##
=============================================
+ Coverage 91.640% 91.679% +0.039%
=============================================
Files 617 617
Lines 50197 50216 +19
Branches 18130 18134 +4
=============================================
+ Hits 46001 46038 +37
+ Misses 4103 4086 -17
+ Partials 93 92 -1
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e84bc3f | 1196.62 ms | 1218.86 ms | 22.24 ms |
3033115 | 1260.10 ms | 1263.58 ms | 3.48 ms |
e072ad1 | 1221.35 ms | 1237.48 ms | 16.13 ms |
fc163f5 | 1219.18 ms | 1242.74 ms | 23.56 ms |
596ccc1 | 1221.57 ms | 1236.82 ms | 15.25 ms |
ecd9ecd | 1215.77 ms | 1238.70 ms | 22.93 ms |
fcde045 | 1197.91 ms | 1224.80 ms | 26.89 ms |
9ccd421 | 1196.90 ms | 1209.63 ms | 12.73 ms |
f8833c4 | 1230.00 ms | 1245.27 ms | 15.27 ms |
3b4110a | 1228.90 ms | 1247.65 ms | 18.76 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e84bc3f | 20.76 KiB | 434.72 KiB | 413.96 KiB |
3033115 | 22.85 KiB | 405.84 KiB | 382.99 KiB |
e072ad1 | 21.58 KiB | 625.82 KiB | 604.24 KiB |
fc163f5 | 20.76 KiB | 436.29 KiB | 415.53 KiB |
596ccc1 | 22.84 KiB | 401.44 KiB | 378.60 KiB |
ecd9ecd | 20.76 KiB | 420.23 KiB | 399.47 KiB |
fcde045 | 20.76 KiB | 435.26 KiB | 414.50 KiB |
9ccd421 | 21.58 KiB | 418.82 KiB | 397.24 KiB |
f8833c4 | 21.58 KiB | 422.66 KiB | 401.08 KiB |
3b4110a | 21.58 KiB | 625.82 KiB | 604.24 KiB |
📜 Description
Add the logic for non-fully-blocking app hangs when the frame delay exceeds 99%.
This PR is based on #4285.
#skip-changelog
💡 Motivation and Context
This is required for GH-3492.
💚 How did you test it?
Running on a real device and unit tests.
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps